Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Unified Diff: chrome/browser/ui/browser.h

Issue 10391158: Moves methods for finding browsers to browser_finder. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Include fixs Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser.h
diff --git a/chrome/browser/ui/browser.h b/chrome/browser/ui/browser.h
index 56cb971ba173808b1f96493f827228fa7c12a73a..16b97edec30fc1bf5389c55aeb443c83938525dd 100644
--- a/chrome/browser/ui/browser.h
+++ b/chrome/browser/ui/browser.h
@@ -271,7 +271,7 @@ class Browser : public TabStripModelDelegate,
// Browser Creation Helpers /////////////////////////////////////////////////
// Opens a new window with the default blank tab.
- static void NewEmptyWindow(Profile* profile);
+ static void NewEmptyWindow(Profile* profile);
// Opens a new window with the default blank tab. This bypasses metrics and
// various internal bookkeeping; NewEmptyWindow (above) is preferred.
@@ -680,27 +680,6 @@ class Browser : public TabStripModelDelegate,
// Helper function to run unload listeners on a WebContents.
static bool RunUnloadEventsHelper(content::WebContents* contents);
- // Returns the Browser which contains the tab with the given
- // NavigationController, also filling in |index| (if valid) with the tab's
- // index in the tab strip.
- // Returns NULL if not found.
- // This call is O(N) in the number of tabs.
- static Browser* GetBrowserForController(
- const content::NavigationController* controller, int* index);
-
- // Retrieve the last active tabbed browser with a profile matching |profile|.
- // If |match_original_profiles| is true, matching is done based on the
- // original profile, eg profile->GetOriginalProfile() ==
- // browser->profile()->GetOriginalProfile(). This has the effect of matching
- // against both non-incognito and incognito profiles. If
- // |match_original_profiles| is false, only an exact match may be returned.
- static Browser* GetTabbedBrowser(Profile* profile,
- bool match_original_profiles);
-
- // Retrieve the last active tabbed browser with a profile matching |profile|.
- // Creates a new Browser if none are available.
- static Browser* GetOrCreateTabbedBrowser(Profile* profile);
-
// Helper function to display the file selection dialog.
static void RunFileChooserHelper(
content::WebContents* tab, const content::FileChooserParams& params);

Powered by Google App Engine
This is Rietveld 408576698