Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5397)

Unified Diff: chrome/browser/extensions/extension_install_ui.cc

Issue 10391158: Moves methods for finding browsers to browser_finder. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Include fixs Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_install_ui.cc
diff --git a/chrome/browser/extensions/extension_install_ui.cc b/chrome/browser/extensions/extension_install_ui.cc
index 9d1df2cb5080b6aa88f0579ba956b4ab616f2225..db904af4ee04d61ab3245ec44a6a9bc82c34fcd5 100644
--- a/chrome/browser/extensions/extension_install_ui.cc
+++ b/chrome/browser/extensions/extension_install_ui.cc
@@ -22,7 +22,7 @@
#include "chrome/browser/themes/theme_service_factory.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_dialogs.h"
-#include "chrome/browser/ui/browser_list.h"
+#include "chrome/browser/ui/browser_finder.h"
#include "chrome/browser/ui/browser_navigator.h"
#include "chrome/browser/ui/browser_window.h"
#include "chrome/browser/ui/simple_message_box.h"
@@ -364,7 +364,7 @@ void ExtensionInstallUI::OnInstallSuccess(const Extension* extension,
// Extensions aren't enabled by default in incognito so we confirm
// the install in a normal window.
Profile* profile = profile_->GetOriginalProfile();
- Browser* browser = Browser::GetOrCreateTabbedBrowser(profile);
+ Browser* browser = browser::FindOrCreateTabbedBrowser(profile);
if (browser->tab_count() == 0)
browser->AddBlankTab(true);
browser->window()->Show();
@@ -396,7 +396,7 @@ void ExtensionInstallUI::OnInstallFailure(const string16& error) {
if (disable_failure_ui_for_tests || skip_post_install_ui_)
return;
- Browser* browser = BrowserList::GetLastActiveWithProfile(profile_);
+ Browser* browser = browser::FindLastActiveWithProfile(profile_);
browser::ShowMessageBox(browser ? browser->window()->GetNativeHandle() : NULL,
l10n_util::GetStringUTF16(IDS_EXTENSION_INSTALL_FAILURE_TITLE), error,
browser::MESSAGE_BOX_TYPE_WARNING);
@@ -457,7 +457,7 @@ void ExtensionInstallUI::ShowThemeInfoBar(const std::string& previous_theme_id,
return;
// Get last active tabbed browser of profile.
- Browser* browser = BrowserList::FindTabbedBrowser(profile, true);
+ Browser* browser = browser::FindTabbedBrowser(profile, true);
if (!browser)
return;

Powered by Google App Engine
This is Rietveld 408576698