Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Unified Diff: chrome/browser/automation/testing_automation_provider.cc

Issue 10391158: Moves methods for finding browsers to browser_finder. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Include fixs Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/automation/testing_automation_provider.cc
diff --git a/chrome/browser/automation/testing_automation_provider.cc b/chrome/browser/automation/testing_automation_provider.cc
index 13388a995ae0e6696ecaee114fb60cdb0cfa7adb..51a8928605fb1b305422df170e794b2c8a490468 100644
--- a/chrome/browser/automation/testing_automation_provider.cc
+++ b/chrome/browser/automation/testing_automation_provider.cc
@@ -98,6 +98,8 @@
#include "chrome/browser/ui/app_modal_dialogs/native_app_modal_dialog.h"
#include "chrome/browser/ui/blocked_content/blocked_content_tab_helper.h"
#include "chrome/browser/ui/bookmarks/bookmark_bar.h"
+#include "chrome/browser/ui/browser_finder.h"
+#include "chrome/browser/ui/browser_list.h"
#include "chrome/browser/ui/browser_window.h"
#include "chrome/browser/ui/find_bar/find_bar.h"
#include "chrome/browser/ui/fullscreen_controller.h"
@@ -643,7 +645,7 @@ void TestingAutomationProvider::CloseTab(int tab_handle,
if (tab_tracker_->ContainsHandle(tab_handle)) {
NavigationController* controller = tab_tracker_->GetResource(tab_handle);
int index;
- Browser* browser = Browser::GetBrowserForController(controller, &index);
+ Browser* browser = browser::FindBrowserForController(controller, &index);
DCHECK(browser);
new TabClosedNotificationObserver(this, wait_until_closed, reply_message);
browser->CloseTabContents(controller->GetWebContents());
@@ -760,8 +762,7 @@ void TestingAutomationProvider::GetBrowserWindowCount(int* window_count) {
}
void TestingAutomationProvider::GetNormalBrowserWindowCount(int* window_count) {
- *window_count = static_cast<int>(
- BrowserList::GetBrowserCountForType(profile_, true));
+ *window_count = static_cast<int>(browser::GetTabbedBrowserCount(profile_));
}
void TestingAutomationProvider::GetBrowserWindow(int index, int* handle) {
@@ -773,7 +774,7 @@ void TestingAutomationProvider::GetBrowserWindow(int index, int* handle) {
void TestingAutomationProvider::FindTabbedBrowserWindow(int* handle) {
*handle = 0;
- Browser* browser = BrowserList::FindTabbedBrowser(profile_, false);
+ Browser* browser = browser::FindTabbedBrowser(profile_, false);
if (browser)
*handle = browser_tracker_->Add(browser);
}
@@ -1265,7 +1266,7 @@ void TestingAutomationProvider::GetTabIndex(int handle, int* tabstrip_index) {
if (tab_tracker_->ContainsHandle(handle)) {
NavigationController* tab = tab_tracker_->GetResource(handle);
- Browser* browser = Browser::GetBrowserForController(tab, NULL);
+ Browser* browser = browser::FindBrowserForController(tab, NULL);
*tabstrip_index = browser->GetIndexOfController(tab);
}
}
@@ -7121,7 +7122,7 @@ void TestingAutomationProvider::GetParentBrowserOfTab(int tab_handle,
if (tab_tracker_->ContainsHandle(tab_handle)) {
NavigationController* controller = tab_tracker_->GetResource(tab_handle);
int index;
- Browser* browser = Browser::GetBrowserForController(controller, &index);
+ Browser* browser = browser::FindBrowserForController(controller, &index);
if (browser) {
*browser_handle = browser_tracker_->Add(browser);
*success = true;

Powered by Google App Engine
This is Rietveld 408576698