Issue 10391153: Revert "Make setup.exe compatible with the component build."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10391153: Revert "Make setup.exe compatible with the component build." (Closed)

Created:
8 years, 7 months ago by gab

Modified:
8 years, 7 months ago

Reviewers:
robertshield

CC:
chromium-reviews, grt+watch_chromium.org, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Revert "Make setup.exe compatible with the component build." This reverts commit 455e64b6dbd407befca3ec7fc83c5fa861df1c44. It was breaking CRT DLL lookups for some people in VS2008. BUG=127233 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137330

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+2 lines, -196 lines)			Patch
build/common.gypi	View	1 chunk	+0 lines, -17 lines	0 comments	Download
chrome/chrome_exe.gypi	View	1 chunk	+0 lines, -15 lines	0 comments	Download
chrome/chrome_installer.gypi	View	1 chunk	+0 lines, -15 lines	0 comments	Download
chrome/installer/mini_installer.gyp	View	2 chunks	+0 lines, -10 lines	0 comments	Download
chrome/installer/setup/install_worker.cc	View	1 chunk	+0 lines, -20 lines	0 comments	Download
chrome/tools/build/win/create_installer_archive.py	View	4 chunks	+2 lines, -119 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gab@chromium.org/10391153/1

8 years, 7 months ago (2012-05-15 23:35:31 UTC) #3

Change committed as 137330

Expand Messages | Collapse Messages