Issue 10391097: importer: Make use of ShowMessageBox() function in ImporterHost.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10391097: importer: Make use of ShowMessageBox() function in ImporterHost. (Closed)

Created:
8 years, 7 months ago by tfarina

Modified:
8 years, 1 month ago

Reviewers:
Peter Kasting, Miranda Callahan

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

importer: Make use of ShowMessageBox() function in ImporterHost. This makes ImporterHost use the cross platform function instead of using the one that is Windows specific. R=pkasting@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137479

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -11 lines)			Patch
	M	chrome/browser/importer/importer_host.cc	View		3 chunks	+4 lines, -11 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

tfarina

Peter, would you review this to me? If not, could you suggest a better reviewer?

8 years, 7 months ago (2012-05-15 02:43:32 UTC) #2

Peter Kasting

LGTM. This leaves very few callers of the Windows ui::MessageBox() function. Are you planning to ...

8 years, 7 months ago (2012-05-15 18:32:42 UTC) #3

Peter Kasting

8 years, 1 month ago (2012-11-20 06:57:50 UTC) #4

I didn't review this closely enough.  The two functions don't declare their
arguments in the same order.  The old function took the text and then the
caption, the new one takes the caption and then the text.  Can you fix this?

Expand Messages | Collapse Messages