Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Unified Diff: chrome/browser/sync/glue/typed_url_data_type_controller.h

Issue 10391080: No longer keep a lingering reference to TypedUrlDataTypeController after PSS exits (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Allow DTC deletion on non-UI threads. Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/glue/typed_url_data_type_controller.h
diff --git a/chrome/browser/sync/glue/typed_url_data_type_controller.h b/chrome/browser/sync/glue/typed_url_data_type_controller.h
index 11145d2727d44ba604dc4e0e136cd1c28107bb5b..411dca54b0a49bc5ca6b14f57967716776219a8e 100644
--- a/chrome/browser/sync/glue/typed_url_data_type_controller.h
+++ b/chrome/browser/sync/glue/typed_url_data_type_controller.h
@@ -45,15 +45,9 @@ class TypedUrlDataTypeController : public NonFrontendDataTypeController,
const content::NotificationSource& source,
const content::NotificationDetails& details) OVERRIDE;
- // CancelableRequestConsumerBase implementation.
- virtual void OnRequestAdded(CancelableRequestProvider* provider,
- CancelableRequestProvider::Handle handle) {}
- virtual void OnRequestRemoved(CancelableRequestProvider* provider,
- CancelableRequestProvider::Handle handle) {}
- virtual void WillExecute(CancelableRequestProvider* provider,
- CancelableRequestProvider::Handle handle) {}
- virtual void DidExecute(CancelableRequestProvider* provider,
- CancelableRequestProvider::Handle handle) {}
+ // Invoked on the history thread to set our history backend - must be called
+ // before CreateSyncComponents() is invoked.
+ void SetBackend(history::HistoryBackend* backend);
protected:
// NonFrontendDataTypeController interface.
@@ -66,12 +60,7 @@ class TypedUrlDataTypeController : public NonFrontendDataTypeController,
private:
virtual ~TypedUrlDataTypeController();
- // Used by PostTaskOnBackendThread().
- void RunTaskOnBackendThread(const base::Closure& task,
- history::HistoryBackend* backend);
-
history::HistoryBackend* backend_;
- scoped_refptr<HistoryService> history_service_;
content::NotificationRegistrar notification_registrar_;
PrefChangeRegistrar pref_registrar_;

Powered by Google App Engine
This is Rietveld 408576698