convert chromeos file manager to loadTimeData

convert chromeos file manager to loadTimeData

BUG=122753
TEST=manual,unit

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137692

[Dmitry Zvorygin, 2012-05-12 09:39:16]

Good changelist. LGTM.

[Vladislav Kaznacheev, 2012-05-12 09:50:34]

I am working on a change that touches the same places (for instance I am
renaming "ENABLE_GDATA"). I am perfectly OK with merging/rebasing on this patch
once it is committed. Now my question is: I am going to merge my patch into M20,
will I find a working loadTimeData there?

[Vladislav Kaznacheev, 2012-05-12 09:51:40]

lgtm

[Evan Stade, 2012-05-14 20:08:32]

On 2012/05/12 09:50:34, Vladislav Kaznacheev wrote:
> I am working on a change that touches the same places (for instance I am
> renaming "ENABLE_GDATA"). I am perfectly OK with merging/rebasing on this
patch
> once it is committed. Now my question is: I am going to merge my patch into
M20,
> will I find a working loadTimeData there?

yes, but you would have to merge this patch as well. I think it would be best to
not merge this, so you should land your change first and I will rebase.

[kaznacheev, 2012-05-14 21:27:57]

Great! I will commit tomorrow and let you know

My iPad made me send this.

On May 15, 2012, at 0:08, "estade@chromium.org" <estade@chromium.org> wrote:

> On 2012/05/12 09:50:34, Vladislav Kaznacheev wrote:
>> I am working on a change that touches the same places (for instance I am
>> renaming "ENABLE_GDATA"). I am perfectly OK with merging/rebasing on this
> patch
>> once it is committed. Now my question is: I am going to merge my patch into
> M20,
>> will I find a working loadTimeData there?
>
> yes, but you would have to merge this patch as well. I think it would be best
to
> not merge this, so you should land your change first and I will rebase.
>
> http://codereview.chromium.org/10391075/

[Vladislav Kaznacheev, 2012-05-15 10:46:09]

https://chromiumcodereview.appspot.com/10391103/ is in. You are going to have
one merge conflict for sure (around 'ENABLE_GDATA' in file_manager.js), but
that's about it.

On 2012/05/14 21:27:57, kaznacheev wrote:
> Great! I will commit tomorrow and let you know
> 
> My iPad made me send this.
> 
> On May 15, 2012, at 0:08, "estade@chromium.org" <mailto:estade@chromium.org>
wrote:
> 
> > On 2012/05/12 09:50:34, Vladislav Kaznacheev wrote:
> >> I am working on a change that touches the same places (for instance I am
> >> renaming "ENABLE_GDATA"). I am perfectly OK with merging/rebasing on this
> > patch
> >> once it is committed. Now my question is: I am going to merge my patch into
> > M20,
> >> will I find a working loadTimeData there?
> >
> > yes, but you would have to merge this patch as well. I think it would be
best
> to
> > not merge this, so you should land your change first and I will rebase.
> >
> > http://codereview.chromium.org/10391075/

[Evan Stade, 2012-05-17 00:08:36]

sync'd. Want to take another look?

[Vladislav Kaznacheev, 2012-05-17 09:07:38]

lgtm