Issue 10391061: Fix compose-discard crasher from 11524 - port to x64, ARM, MIPS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10391061: Fix compose-discard crasher from 11524 - port to x64, ARM, MIPS. (Closed)

Created:
8 years, 7 months ago by Erik Corry

Modified:
8 years, 7 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

Fix compose-discard crasher from 11524 - port to x64, ARM, MIPS. This is now bug 2123. TBR=mstarzinger Committed: https://code.google.com/p/v8/source/detail?r=11540

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+52 lines, -32 lines)			Patch
M	src/arm/lithium-codegen-arm.cc	View	2 chunks	+18 lines, -11 lines	0 comments	Download
M	src/mips/lithium-codegen-mips.cc	View	2 chunks	+16 lines, -10 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	2 chunks	+18 lines, -11 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

8 years, 7 months ago (2012-05-11 11:58:29 UTC) #2

Same comments as in the original CL, but you already took care of that in the
follow-up cleanup CL. So LGTM if combined with the following.

https://chromiumcodereview.appspot.com/10386089/

Expand Messages | Collapse Messages