History: Rename Page to Visit, remove some unused code, other cleanups.

History: Rename Page to Visit, remove some unused code, other cleanups.

The term "Page" had a double meaning -- either a visit, or a portion
of the full list of visits. The term visit is more appropriate for
the former, and it better matches the terminology in the history
backend.

Also remove some unused code, and make a few style cleanups.

BUG=None
TEST=Manual

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137856

[Patrick Dubroy, 2012-05-10 16:52:01]

Hey Erik, please take a look. Just some small cleanups that I wanted to do
before doing a bigger refactor of some of the code.

http://codereview.chromium.org/10391052/diff/1/chrome/browser/resources/histo...
File chrome/browser/resources/history/history.js (left):

http://codereview.chromium.org/10391052/diff/1/chrome/browser/resources/histo...
chrome/browser/resources/history/history.js:168: console.error('Already
generated node for page.');
This is not actually an error -- it happens whenever you view a page of results
that you already viewed before.

[Patrick Dubroy, 2012-05-11 07:19:38]

Erik, please take a look. I forgot to actually add you as a reviewer before.

[Patrick Dubroy, 2012-05-15 20:41:47]

On 2012/05/11 07:19:38, dubroy wrote:
> Erik, please take a look. I forgot to actually add you as a reviewer before.

Ping.

[Patrick Dubroy, 2012-05-16 14:59:30]

Evan, can you review?

[Evan Stade, 2012-05-16 23:59:47]

lgtm

[commit-bot: I haz the power, 2012-05-18 13:43:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dubroy@chromium.org/10391052/1