Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Unified Diff: chrome/browser/resources/sync_promo/sync_promo.js

Issue 10391044: retry 136193 - convert localStrings to loadTimeData for options page (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: sync Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/sync_promo/sync_promo.html ('k') | chrome/browser/resources/sync_setup_overlay.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/sync_promo/sync_promo.js
diff --git a/chrome/browser/resources/sync_promo/sync_promo.js b/chrome/browser/resources/sync_promo/sync_promo.js
index 20aa64a7d05e21b8be8c4c721364cfb3a485068f..3173b8259c94011f2e7b098a3555107bedb930d0 100644
--- a/chrome/browser/resources/sync_promo/sync_promo.js
+++ b/chrome/browser/resources/sync_promo/sync_promo.js
@@ -16,8 +16,8 @@ cr.define('sync_promo', function() {
*/
function SyncPromo() {
options.SyncSetupOverlay.call(this, 'syncSetup',
- templateData.syncSetupOverlayTabTitle,
- 'sync-setup-overlay');
+ loadTimeData.getString('syncSetupOverlayTabTitle'),
+ 'sync-setup-overlay');
}
// Replicating enum from chrome/common/extensions/extension_constants.h.
@@ -56,8 +56,6 @@ cr.define('sync_promo', function() {
// Initializes the page.
initializePage: function() {
- localStrings = new LocalStrings();
-
options.SyncSetupOverlay.prototype.initializePage.call(this);
// Hide parts of the login UI and show the promo UI.
« no previous file with comments | « chrome/browser/resources/sync_promo/sync_promo.html ('k') | chrome/browser/resources/sync_setup_overlay.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698