Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2243)

Unified Diff: chrome/browser/resources/options2/chromeos/change_picture_options.js

Issue 10391044: retry 136193 - convert localStrings to loadTimeData for options page (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: sync Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options2/chromeos/change_picture_options.js
diff --git a/chrome/browser/resources/options2/chromeos/change_picture_options.js b/chrome/browser/resources/options2/chromeos/change_picture_options.js
index 4f95a983bca1318728f01f6292493d188c137ee2..abdfa63f9ab6f32ca854493969417a1bcbb22c7e 100644
--- a/chrome/browser/resources/options2/chromeos/change_picture_options.js
+++ b/chrome/browser/resources/options2/chromeos/change_picture_options.js
@@ -29,7 +29,7 @@ cr.define('options', function() {
OptionsPage.call(
this,
'changePicture',
- localStrings.getString('changePicturePage'),
+ loadTimeData.getString('changePicturePage'),
'change-picture-page');
}
@@ -62,13 +62,13 @@ cr.define('options', function() {
if (!this.userIsEphemeral_()) {
// Add the "Choose file" button.
imageGrid.addItem(ButtonImages.CHOOSE_FILE,
- localStrings.getString('chooseFile'),
+ loadTimeData.getString('chooseFile'),
this.handleChooseFile_.bind(this));
// Profile image data.
this.profileImage_ = imageGrid.addItem(
ButtonImages.PROFILE_PICTURE,
- localStrings.getString('profilePhotoLoading'));
+ loadTimeData.getString('profilePhotoLoading'));
}
// Old user image data (if present).
@@ -203,7 +203,7 @@ cr.define('options', function() {
if (showTakePhotoButton && !this.takePhotoButton_) {
this.takePhotoButton_ = imageGrid.addItem(
ButtonImages.TAKE_PHOTO,
- localStrings.getString('takePhoto'),
+ loadTimeData.getString('takePhoto'),
this.handleTakePhoto_.bind(this),
1);
} else if (!showTakePhotoButton && this.takePhotoButton_) {
@@ -239,7 +239,7 @@ cr.define('options', function() {
setProfileImage_: function(imageUrl, select) {
var imageGrid = $('images-grid');
this.profileImage_ = imageGrid.updateItem(
- this.profileImage_, imageUrl, localStrings.getString('profilePhoto'));
+ this.profileImage_, imageUrl, loadTimeData.getString('profilePhoto'));
if (select)
imageGrid.selectedItem = this.profileImage_;
},
@@ -271,7 +271,7 @@ cr.define('options', function() {
* @private
*/
userIsEphemeral_: function() {
- return localStrings.getString('userIsEphemeral') == 'true';
+ return loadTimeData.getBoolean('userIsEphemeral');
},
};

Powered by Google App Engine
This is Rietveld 408576698