Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Side by Side Diff: chrome/browser/resources/options2/handler_options_list.js

Issue 10391044: retry 136193 - convert localStrings to loadTimeData for options page (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: sync Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 cr.define('options', function() { 5 cr.define('options', function() {
6 /** @const */ var ArrayDataModel = cr.ui.ArrayDataModel; 6 /** @const */ var ArrayDataModel = cr.ui.ArrayDataModel;
7 /** @const */ var List = cr.ui.List; 7 /** @const */ var List = cr.ui.List;
8 /** @const */ var ListItem = cr.ui.ListItem; 8 /** @const */ var ListItem = cr.ui.ListItem;
9 /** @const */ var HandlerOptions = options.HandlerOptions; 9 /** @const */ var HandlerOptions = options.HandlerOptions;
10 /** @const */ var DeletableItem = options.DeletableItem; 10 /** @const */ var DeletableItem = options.DeletableItem;
11 /** @const */ var DeletableItemList = options.DeletableItemList; 11 /** @const */ var DeletableItemList = options.DeletableItemList;
12 12
13 /** @const */ var localStrings = new LocalStrings();
14
15 /** 13 /**
16 * Creates a new ignored protocol / content handler list item. 14 * Creates a new ignored protocol / content handler list item.
17 * 15 *
18 * Accepts values in the form 16 * Accepts values in the form
19 * ['mailto', 'http://www.thesite.com/%s', 'The title of the protocol'], 17 * ['mailto', 'http://www.thesite.com/%s', 'The title of the protocol'],
20 * @param {Object} entry A dictionary describing the handlers for a given 18 * @param {Object} entry A dictionary describing the handlers for a given
21 * protocol. 19 * protocol.
22 * @constructor 20 * @constructor
23 * @extends {cr.ui.DeletableItemList} 21 * @extends {cr.ui.DeletableItemList}
24 */ 22 */
(...skipping 94 matching lines...) Expand 10 before | Expand all | Expand 10 after
119 protocolElement.textContent = data.protocol; 117 protocolElement.textContent = data.protocol;
120 protocolElement.className = 'handlers-type-column'; 118 protocolElement.className = 'handlers-type-column';
121 this.appendChild(protocolElement); 119 this.appendChild(protocolElement);
122 120
123 // Handler selection. 121 // Handler selection.
124 var handlerElement = document.createElement('div'); 122 var handlerElement = document.createElement('div');
125 var selectElement = document.createElement('select'); 123 var selectElement = document.createElement('select');
126 var defaultOptionElement = document.createElement('option'); 124 var defaultOptionElement = document.createElement('option');
127 defaultOptionElement.selected = data.default_handler == -1; 125 defaultOptionElement.selected = data.default_handler == -1;
128 defaultOptionElement.textContent = 126 defaultOptionElement.textContent =
129 localStrings.getString('handlers_none_handler'); 127 loadTimeData.getString('handlers_none_handler');
130 defaultOptionElement.value = -1; 128 defaultOptionElement.value = -1;
131 selectElement.appendChild(defaultOptionElement); 129 selectElement.appendChild(defaultOptionElement);
132 130
133 for (var i = 0; i < data.handlers.length; ++i) { 131 for (var i = 0; i < data.handlers.length; ++i) {
134 var optionElement = document.createElement('option'); 132 var optionElement = document.createElement('option');
135 optionElement.selected = i == data.default_handler; 133 optionElement.selected = i == data.default_handler;
136 optionElement.textContent = data.handlers[i][2]; 134 optionElement.textContent = data.handlers[i][2];
137 optionElement.value = i; 135 optionElement.value = i;
138 selectElement.appendChild(optionElement); 136 selectElement.appendChild(optionElement);
139 } 137 }
(...skipping 10 matching lines...) Expand all
150 }); 148 });
151 handlerElement.appendChild(selectElement); 149 handlerElement.appendChild(selectElement);
152 handlerElement.className = 'handlers-site-column'; 150 handlerElement.className = 'handlers-site-column';
153 if (data.default_handler == -1) 151 if (data.default_handler == -1)
154 this.classList.add('none'); 152 this.classList.add('none');
155 this.appendChild(handlerElement); 153 this.appendChild(handlerElement);
156 154
157 // Remove link. 155 // Remove link.
158 var removeElement = document.createElement('div'); 156 var removeElement = document.createElement('div');
159 removeElement.textContent = 157 removeElement.textContent =
160 localStrings.getString('handlers_remove_link'); 158 loadTimeData.getString('handlers_remove_link');
161 removeElement.addEventListener('click', function(e) { 159 removeElement.addEventListener('click', function(e) {
162 var value = selectElement ? selectElement.value : 0; 160 var value = selectElement ? selectElement.value : 0;
163 delegate.removeHandler(value, data.handlers[value]); 161 delegate.removeHandler(value, data.handlers[value]);
164 }); 162 });
165 removeElement.className = 'handlers-remove-column handlers-remove-link'; 163 removeElement.className = 'handlers-remove-column handlers-remove-link';
166 this.appendChild(removeElement); 164 this.appendChild(removeElement);
167 }, 165 },
168 166
169 /** @inheritDoc */ 167 /** @inheritDoc */
170 decorate: function() { 168 decorate: function() {
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
220 }, 218 },
221 }; 219 };
222 220
223 return { 221 return {
224 IgnoredHandlersListItem: IgnoredHandlersListItem, 222 IgnoredHandlersListItem: IgnoredHandlersListItem,
225 IgnoredHandlersList: IgnoredHandlersList, 223 IgnoredHandlersList: IgnoredHandlersList,
226 HandlerListItem: HandlerListItem, 224 HandlerListItem: HandlerListItem,
227 HandlersList: HandlersList, 225 HandlersList: HandlersList,
228 }; 226 };
229 }); 227 });
OLDNEW
« no previous file with comments | « chrome/browser/resources/options2/handler_options.js ('k') | chrome/browser/resources/options2/home_page_overlay.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698