Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10391002: Hide invalid datalist suggestions (Closed)

Created:
8 years, 7 months ago by keishi
Modified:
8 years, 7 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, dhollowa+watch_chromium.org, brettw-cc_chromium.org, Ilya Sherman, dyu1, darin-cc_chromium.org
Visibility:
Public.

Description

Hide invalid datalist suggestions BUG=126620 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137360

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/renderer/autofill/autofill_agent.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
keishi
Datalist suggestions that are invalid for that type of input should be hidden. https://bugs.webkit.org/show_bug.cgi?id=84344
8 years, 7 months ago (2012-05-08 10:11:29 UTC) #1
Ilya Sherman
lgtm
8 years, 7 months ago (2012-05-08 23:47:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keishi@chromium.org/10391002/1
8 years, 7 months ago (2012-05-08 23:48:51 UTC) #3
commit-bot: I haz the power
Try job failure for 10391002-1 (retry) on win_rel for step "browser_tests". It's a second try, ...
8 years, 7 months ago (2012-05-09 03:36:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keishi@chromium.org/10391002/1
8 years, 7 months ago (2012-05-15 10:20:48 UTC) #5
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test. Builder is ...
8 years, 7 months ago (2012-05-15 11:32:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keishi@chromium.org/10391002/1
8 years, 7 months ago (2012-05-16 02:32:06 UTC) #7
commit-bot: I haz the power
8 years, 7 months ago (2012-05-16 04:13:43 UTC) #8 
Change committed as 137360

Powered by Google App Engine
This is Rietveld 408576698