Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Side by Side Diff: chrome/browser/nacl_host/nacl_process_host.cc

Issue 10389229: NaCl: Remove duplicated logging for the process exit status (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/nacl_host/nacl_process_host.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/nacl_host/nacl_process_host.h" 5 #include "chrome/browser/nacl_host/nacl_process_host.h"
6 6
7 #include <string> 7 #include <string>
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/bind.h" 10 #include "base/bind.h"
(...skipping 511 matching lines...) Expand 10 before | Expand all | Expand 10 after
522 OnSetKnownToValidate) 522 OnSetKnownToValidate)
523 #if defined(OS_WIN) 523 #if defined(OS_WIN)
524 IPC_MESSAGE_HANDLER_DELAY_REPLY(NaClProcessMsg_AttachDebugExceptionHandler, 524 IPC_MESSAGE_HANDLER_DELAY_REPLY(NaClProcessMsg_AttachDebugExceptionHandler,
525 OnAttachDebugExceptionHandler) 525 OnAttachDebugExceptionHandler)
526 #endif 526 #endif
527 IPC_MESSAGE_UNHANDLED(handled = false) 527 IPC_MESSAGE_UNHANDLED(handled = false)
528 IPC_END_MESSAGE_MAP() 528 IPC_END_MESSAGE_MAP()
529 return handled; 529 return handled;
530 } 530 }
531 531
532 void NaClProcessHost::OnProcessCrashed(int exit_code) {
533 std::string message = base::StringPrintf(
534 "NaCl process exited with status %i (0x%x)", exit_code, exit_code);
535 LOG(ERROR) << message;
536 }
537
538 void NaClProcessHost::OnProcessLaunched() { 532 void NaClProcessHost::OnProcessLaunched() {
539 if (!StartWithLaunchedProcess()) 533 if (!StartWithLaunchedProcess())
540 delete this; 534 delete this;
541 } 535 }
542 536
543 // Called when the NaClBrowser singleton has been fully initialized. 537 // Called when the NaClBrowser singleton has been fully initialized.
544 void NaClProcessHost::OnResourcesReady() { 538 void NaClProcessHost::OnResourcesReady() {
545 NaClBrowser* nacl_browser = NaClBrowser::GetInstance(); 539 NaClBrowser* nacl_browser = NaClBrowser::GetInstance();
546 if (!nacl_browser->IsReady() || !SendStart()) { 540 if (!nacl_browser->IsReady() || !SendStart()) {
547 DLOG(ERROR) << "Cannot launch NaCl process"; 541 DLOG(ERROR) << "Cannot launch NaCl process";
(...skipping 209 matching lines...) Expand 10 before | Expand all | Expand 10 after
757 } else { 751 } else {
758 NaClStartDebugExceptionHandlerThread( 752 NaClStartDebugExceptionHandlerThread(
759 process_handle.Take(), info, 753 process_handle.Take(), info,
760 base::MessageLoopProxy::current(), 754 base::MessageLoopProxy::current(),
761 base::Bind(&NaClProcessHost::OnDebugExceptionHandlerLaunchedByBroker, 755 base::Bind(&NaClProcessHost::OnDebugExceptionHandlerLaunchedByBroker,
762 weak_factory_.GetWeakPtr())); 756 weak_factory_.GetWeakPtr()));
763 return true; 757 return true;
764 } 758 }
765 } 759 }
766 #endif 760 #endif
OLDNEW
« no previous file with comments | « chrome/browser/nacl_host/nacl_process_host.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698