Issue 10389228: browser: Rename message_box_handler.* to javascript_dialog_creator.*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10389228: browser: Rename message_box_handler.* to javascript_dialog_creator.* (Closed)

Created:
8 years, 7 months ago by tfarina

Modified:
8 years, 7 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org, dcheng

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

browser: Rename message_box_handler.* to javascript_dialog_creator.* So the filename matches much more with the free function names used in the header file and with the class name used in the source file. R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138398

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+29 lines, -330 lines)			Patch
M	chrome/browser/extensions/extension_host.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/external_tab/external_tab_container_win.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	chrome/browser/ui/app_modal_dialogs/javascript_dialog_creator.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
A +	chrome/browser/ui/app_modal_dialogs/javascript_dialog_creator.cc	View	7 chunks	+19 lines, -19 lines	0 comments	Download
D	chrome/browser/ui/app_modal_dialogs/message_box_handler.h	View	1 chunk	+0 lines, -25 lines	0 comments	Download
D	chrome/browser/ui/app_modal_dialogs/message_box_handler.cc	View	1 chunk	+0 lines, -276 lines	0 comments	Download
M	chrome/browser/ui/browser.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/gtk/tabs/dragged_tab_controller_gtk.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/tabs/tab_drag_controller.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 2 (0 generated)

lgtm