Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Issue 10389227: Base: Add power requirements to the System monitor. (Closed)

Created:
8 years, 7 months ago by rvargas (doing something else)
Modified:
8 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews, erikwright (departed), brettw-cc_chromium.org
Visibility:
Public.

Description

Base: Add power requirements to the System monitor. The only thing we need in the short term is CPU_REQUIRED, and that part is implemented for all platforms (as far as it makes sense). The other options are implemented for Windows, but given that currently there's no user, I expect the implementation for other platforms to be written when there's an actual need for it. BUG=126591 TEST=none Original review: https://chromiumcodereview.appspot.com/10406012/ TBR=brettw Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138011

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+240 lines, -3 lines) Patch
M base/system_monitor/system_monitor.h View 4 chunks +31 lines, -0 lines 0 comments Download
M base/system_monitor/system_monitor_android.cc View 2 chunks +17 lines, -1 line 0 comments Download
M base/system_monitor/system_monitor_posix.cc View 2 chunks +17 lines, -1 line 0 comments Download
M base/system_monitor/system_monitor_unittest.cc View 1 chunk +28 lines, -0 lines 0 comments Download
M base/system_monitor/system_monitor_win.cc View 1 2 chunks +147 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
rvargas (doing something else)
Patch set 1 was the original review. Patch set 2 is the fix for the ...
8 years, 7 months ago (2012-05-19 02:10:05 UTC) #1
brettw
8 years, 7 months ago (2012-05-19 03:27:17 UTC) #2
On Fri, May 18, 2012 at 7:10 PM,  <rvargas@chromium.org> wrote:
> Reviewers: brettw,
>
> Message:
> Patch set 1 was the original review.
> Patch set 2 is the fix for the bots.
>
> Description:
> Base: Add power requirements to the System monitor.
>
> The only thing we need in the short term is CPU_REQUIRED,
> and that part is implemented for all platforms (as far as it
> makes sense). The other options are implemented for Windows,
> but given that currently there's no user, I expect the
> implementation for other platforms to be written when there's
> an actual need for it.
>
> BUG=126591
> TEST=none
>
> Original review: https://chromiumcodereview.appspot.com/10406012/
> TBR=brettw
>
> Please review this at https://chromiumcodereview.appspot.com/10389227/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     base/system_monitor/system_monitor.h
>  M     base/system_monitor/system_monitor_android.cc
>  M     base/system_monitor/system_monitor_posix.cc
>  M     base/system_monitor/system_monitor_unittest.cc
>  M     base/system_monitor/system_monitor_win.cc
>
>

LGTM

Powered by Google App Engine
This is Rietveld 408576698