Issue 10389225: ninja windows: support and test for AdditionalIncludeDirectories

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10389225: ninja windows: support and test for AdditionalIncludeDirectories (Closed)

Created:
8 years, 7 months ago by scottmg

Modified:
8 years, 7 months ago

Reviewers:
Nico

CC:
gyp-developer_googlegroups.com

Base URL:
https://gyp.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

ninja windows: support and test for AdditionalIncludeDirectories Normally gyp files use 'includes', or 'msvs_system_include_dirs', but the msvs generator supports AdditionalIncludeDirectories, so add support to ninja for consistency. BUG=127702 Committed: https://code.google.com/p/gyp/source/detail?r=1393

Patch Set 1 #

Total comments: 1

Patch Set 2 : move to AdjustIncludeDirs #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, --1 lines)			Patch
M	pylib/gyp/msvs_emulation.py	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
A	test/win/compiler-flags/additional-include-dirs.cc	View		1 chunk	+10 lines, -0 lines	0 comments	Download
A	test/win/compiler-flags/additional-include-dirs.gyp	View		1 chunk	+20 lines, -0 lines	0 comments	Download
A	test/win/compiler-flags/subdir/header.h	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A	test/win/gyptest-cl-additional-include-dirs.py	View		1 chunk	+22 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Nico

lgtm https://chromiumcodereview.appspot.com/10389225/diff/1/pylib/gyp/msvs_emulation.py File pylib/gyp/msvs_emulation.py (right): https://chromiumcodereview.appspot.com/10389225/diff/1/pylib/gyp/msvs_emulation.py#newcode271 pylib/gyp/msvs_emulation.py:271: cl('AdditionalIncludeDirectories', prefix='/I', map=gyp_to_build_path) I would've expected that in ...

8 years, 7 months ago (2012-05-23 20:38:33 UTC) #2

scottmg

8 years, 7 months ago (2012-05-23 20:49:26 UTC) #3

On 2012/05/23 20:38:33, Nico wrote:
> lgtm
> 
>
https://chromiumcodereview.appspot.com/10389225/diff/1/pylib/gyp/msvs_emulati...
> File pylib/gyp/msvs_emulation.py (right):
> 
>
https://chromiumcodereview.appspot.com/10389225/diff/1/pylib/gyp/msvs_emulati...
> pylib/gyp/msvs_emulation.py:271: cl('AdditionalIncludeDirectories',
prefix='/I',
> map=gyp_to_build_path)
> I would've expected that in AdjustIncludeDirs, but I suppose it doesn't really
> matter. A bit weird that there are now 3 places where includes can be added.

Sounds better to me. Done.

Expand Messages | Collapse Messages