Issue 10389220: Fix some oauth2 test code: put most code in anonymous namespace to avoid

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10389220: Fix some oauth2 test code: put most code in anonymous namespace to avoid (Closed)

Created:
8 years, 7 months ago by Munjal (Google)

Modified:
8 years, 7 months ago

Reviewers:
Andrew T Wilson (Slow)

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Fix some oauth2 test code: put most code in anonymous namespace to avoid ODR violations. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137987

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -7 lines)			Patch
M	chrome/common/net/gaia/oauth2_access_token_fetcher_unittest.cc	View	3 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/common/net/gaia/oauth2_api_call_flow_unittest.cc	View	3 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/common/net/gaia/oauth2_mint_token_fetcher_unittest.cc	View	3 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/common/net/gaia/oauth2_mint_token_flow_unittest.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/common/net/gaia/oauth2_revocation_fetcher_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/munjal@chromium.org/10389220/1

8 years, 7 months ago (2012-05-18 21:59:00 UTC) #3

commit-bot: I haz the power

8 years, 7 months ago (2012-05-18 22:17:17 UTC) #4

Try job failure for 10389220-1 (retry) on linux_chromeos for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

Expand Messages | Collapse Messages