Issue 10389208: Fix Windows Download Path

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10389208: Fix Windows Download Path (Closed)

Created:
8 years, 7 months ago by csharp

Modified:
8 years, 7 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews, pam+watch_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Fix Windows Download Path Replace the os.path.join command since the doesn't generate the intended url path on windows. R=maruel@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137929

Patch Set 1 #

Total comments: 1

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	tools/isolate/run_test_from_archive.py	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

lgtm https://chromiumcodereview.appspot.com/10389208/diff/1/tools/isolate/run_test_from_archive.py File tools/isolate/run_test_from_archive.py (right): https://chromiumcodereview.appspot.com/10389208/diff/1/tools/isolate/run_test_from_archive.py#newcode220 tools/isolate/run_test_from_archive.py:220: download_or_copy(self.remote.rstrip('/') + '/' + item, out) technically, you ...

8 years, 7 months ago (2012-05-18 17:42:29 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/csharp@chromium.org/10389208/1

8 years, 7 months ago (2012-05-18 17:56:09 UTC) #3

Change committed as 137929

Expand Messages | Collapse Messages