Issue 10389197: browser: Remove views includes from enrollment_dialog_view.cc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10389197: browser: Remove views includes from enrollment_dialog_view.cc (Closed)

Created:
8 years, 7 months ago by tfarina

Modified:
8 years, 7 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

browser: Remove views includes from enrollment_dialog_view.cc BUG=125846 R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137916

Patch Set 1 : #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -19 lines)			Patch
	M	chrome/browser/DEPS	View		1 chunk	+0 lines, -2 lines	0 comments	Download
	M	chrome/browser/chromeos/enrollment_dialog_view.cc	View		2 chunks	+5 lines, -17 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

LGTM, but seems like this file should move to src/chrome/browser/ui/views/chromeos (a new directory)

8 years, 7 months ago (2012-05-18 16:03:30 UTC) #2

tfarina

On Fri, May 18, 2012 at 1:03 PM, <ben@chromium.org> wrote: > LGTM, but seems like ...

8 years, 7 months ago (2012-05-18 18:55:02 UTC) #3

Ben Goodger (Google)

8 years, 7 months ago (2012-05-18 19:35:17 UTC) #4

OK. Seems like all the views-using code in src/chrome/browser/chromeos
should move to browser/ui/views/chromeos

On Fri, May 18, 2012 at 11:54 AM, Thiago Farina <tfarina@chromium.org>wrote:

> On Fri, May 18, 2012 at 1:03 PM,  <ben@chromium.org> wrote:
> > LGTM, but seems like this file should move to
> >
> I didn't move because this file is include by:
> chrome/browser/chromeos/options/vpn_config_view.cc
> chrome/browser/chromeos/options/wifi_config_view.cc
> chrome/browser/chromeos/options/wimax_config_view.cc
> chrome/browser/chromeos/status/network_menu.cc:
>
> --
> Thiago
>

Expand Messages | Collapse Messages