Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 10389182: NaCl: Re-enable nacl-glibc tests on Windows (retry) (Closed)

Created:
8 years, 7 months ago by Mark Seaborn
Modified:
8 years, 7 months ago
Reviewers:
bradn
CC:
chromium-reviews
Visibility:
Public.

Description

NaCl: Re-enable nacl-glibc tests on Windows (retry) These tests were disabled before because libppruntime.so was failing to link because the link command sometimes hit a command line length limit. We have since worked around the length limit, and libppruntime.so should no longer be built by the tests anyway. This was previously committed as r136913 but it failed on the buildbots and was reverted because of a compile problem with __cpuidex() that has since been fixed. BUG=http://code.google.com/p/nativeclient/issues/detail?id=2648 TEST=nacl_integration Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137565

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M chrome/test/nacl_test_injection/buildbot_nacl_integration.py View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mark Seaborn
8 years, 7 months ago (2012-05-16 21:33:12 UTC) #1
bradn
8 years, 7 months ago (2012-05-16 21:39:17 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698