Issue 10389178: mac: Unbreak shared build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10389178: mac: Unbreak shared build. (Closed)

Created:
8 years, 7 months ago by Nico

Modified:
8 years, 7 months ago

Reviewers:
Lambros

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

mac: Unbreak shared build. It was broken by https://chromiumcodereview.appspot.com/10384140. SOLINK_MODULE(target) out/Release/remoting_host_prefpane.prefPane/Contents/MacOS/remoting_host_prefpane Undefined symbols: "_modp_b64_decode", referenced from: -[Me2MePreferencePane onApply:] in me2me_preference_pane.o ld: symbol(s) not found This doesn't happen in the components build because the prefpane still depends on base via tools/gyp-explain.py remoting_host_prefpane modp_b64 These paths lead from remoting/remoting.gyp:remoting_host_prefpane#target to third_party/modp_b64/modp_b64.gyp:modp_b64#target: remoting/remoting.gyp:remoting_host_prefpane#target -> remoting/remoting.gyp:remoting_base#target -> base/base.gyp:base#target -> third_party/modp_b64/modp_b64.gyp:modp_b64#target BUG=none TEST=none TBR=lambroslambrou Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137489

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	remoting/remoting.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages