Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1794)

Issue 10389161: Cleanup: Misc fixes to MediaDeviceNotifications. (Closed)

Created:
8 years, 7 months ago by Lei Zhang
Modified:
8 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Cleanup: Misc fixes to MediaDeviceNotifications. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137502

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -10 lines) Patch
M chrome/browser/media_gallery/media_device_notifications_linux_unittest.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/media_gallery/media_device_notifications_window_win.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/media_gallery/media_device_notifications_window_win.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/media_gallery/media_device_notifications_window_win_unittest.cc View 1 2 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Lei Zhang
8 years, 7 months ago (2012-05-16 07:31:40 UTC) #1
vandebo (ex-Chrome)
LGTM https://chromiumcodereview.appspot.com/10389161/diff/4002/chrome/browser/media_gallery/media_device_notifications_window_win_unittest.cc File chrome/browser/media_gallery/media_device_notifications_window_win_unittest.cc (right): https://chromiumcodereview.appspot.com/10389161/diff/4002/chrome/browser/media_gallery/media_device_notifications_window_win_unittest.cc#newcode15 chrome/browser/media_gallery/media_device_notifications_window_win_unittest.cc:15: #include "chrome/browser/media_gallery/media_device_notifications_window_win.h" nit: it looks like most files ...
8 years, 7 months ago (2012-05-16 17:00:16 UTC) #2
Lei Zhang
https://chromiumcodereview.appspot.com/10389161/diff/4002/chrome/browser/media_gallery/media_device_notifications_window_win_unittest.cc File chrome/browser/media_gallery/media_device_notifications_window_win_unittest.cc (right): https://chromiumcodereview.appspot.com/10389161/diff/4002/chrome/browser/media_gallery/media_device_notifications_window_win_unittest.cc#newcode15 chrome/browser/media_gallery/media_device_notifications_window_win_unittest.cc:15: #include "chrome/browser/media_gallery/media_device_notifications_window_win.h" On 2012/05/16 17:00:16, vandebo wrote: > nit: ...
8 years, 7 months ago (2012-05-16 19:02:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/10389161/5003
8 years, 7 months ago (2012-05-16 19:04:28 UTC) #4
commit-bot: I haz the power
8 years, 7 months ago (2012-05-16 20:43:52 UTC) #5
Change committed as 137502

Powered by Google App Engine
This is Rietveld 408576698