Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 10389146: Fix one more bug in code generation... (Closed)

Created:
8 years, 7 months ago by khim
Modified:
8 years, 7 months ago
Reviewers:
eaeltsin
CC:
native-client-reviews_googlegroups.com
Base URL:
http://git.chromium.org/native_client/nacl-gcc.git@master
Visibility:
Public.

Description

Fix one more bug in code generation... Example code: int foo() { unsigned int x = 0xf2a3e218; return ((int*)x)[0]; } R=eaeltsin@google.com Committed: https://git.chromium.org/gitweb?p=native_client/nacl-gcc.git;a=commit;h=a4396cf

Patch Set 1 #

Total comments: 6

Patch Set 2 : Requested changes in comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M gcc/config/i386/i386.c View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
khim
8 years, 7 months ago (2012-05-15 16:52:27 UTC) #1
eaeltsin
https://chromiumcodereview.appspot.com/10389146/diff/1/gcc/config/i386/i386.c File gcc/config/i386/i386.c (right): https://chromiumcodereview.appspot.com/10389146/diff/1/gcc/config/i386/i386.c#newcode9380 gcc/config/i386/i386.c:9380: + /* Disallow direct accees to addresses between 2GB ...
8 years, 7 months ago (2012-05-16 13:08:37 UTC) #2
khim
https://chromiumcodereview.appspot.com/10389146/diff/1/gcc/config/i386/i386.c File gcc/config/i386/i386.c (right): https://chromiumcodereview.appspot.com/10389146/diff/1/gcc/config/i386/i386.c#newcode9380 gcc/config/i386/i386.c:9380: + /* Disallow direct accees to addresses between 2GB ...
8 years, 7 months ago (2012-05-16 13:36:12 UTC) #3
eaeltsin
8 years, 7 months ago (2012-05-16 14:04:21 UTC) #4
lgtm if bots are happy

Powered by Google App Engine
This is Rietveld 408576698