Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: dart/lib/compiler/implementation/ssa/tracer.dart

Issue 10389143: Add locations to diagnostics. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dart/lib/compiler/implementation/ssa/tracer.dart
diff --git a/dart/lib/compiler/implementation/ssa/tracer.dart b/dart/lib/compiler/implementation/ssa/tracer.dart
index cfb6b9059b266fdf0254b5adad2f827ee3352ef5..9705569b1c6a56362bccb5c0c7acd0bd5f671df4 100644
--- a/dart/lib/compiler/implementation/ssa/tracer.dart
+++ b/dart/lib/compiler/implementation/ssa/tracer.dart
@@ -160,7 +160,9 @@ class HInstructionStringifier implements HVisitor<String> {
visit(HInstruction node) => node.accept(this);
visitBasicBlock(HBasicBlock node) {
- unreachable();
+ // TODO(floitsch): Need a compiler object.
+ compiler.internalError('conditionExpression should not be called',
+ instruction: node);
}
String temporaryId(HInstruction instruction) {
@@ -420,7 +422,11 @@ class HInstructionStringifier implements HVisitor<String> {
case HType.STRING: type = "string"; break;
case HType.INDEXABLE_PRIMITIVE: type = "string_or_array"; break;
case HType.UNKNOWN: type = 'unknown'; break;
- default: unreachable();
+ default:
+ // TODO(floitsch): Need a compiler object.
+ compiler.internalError('Unexpected type guard.',
+ instruction: node.guardedType);
+ break;
}
StringBuffer envBuffer = new StringBuffer();
List<HInstruction> inputs = node.inputs;

Powered by Google App Engine
This is Rietveld 408576698