Add locations to diagnostics.

dart/lib/compiler/implementation/ssa/codegen.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class SsaCodeGeneratorTask extends CompilerTask {
   SsaCodeGeneratorTask(Compiler compiler) : super(compiler);
   String get name() => 'SSA code generator';
 
 
   String buildJavaScriptFunction(FunctionElement element,
@@ skipping 1293 matching lines @@
 
   visitGoto(HGoto node) {
     assert(currentBlock.successors.length == 1);
     List<HBasicBlock> dominated = currentBlock.dominatedBlocks;
     // With the exception of the entry-node which dominates its successor
     // and the exit node, no block finishing with a 'goto' can have more than
     // one dominated block (since it has only one successor).
     // If the successor is dominated by another block, then the other block
     // is responsible for visiting the successor.
     if (dominated.isEmpty()) return;
-    if (dominated.length > 2) unreachable();
+    if (dominated.length > 2) {
+      compiler.internalError('dominated.length = ${dominated.length}',
+                             instruction: node);
+    }
     if (dominated.length == 2 && currentBlock !== currentGraph.entry) {
-      unreachable();
+      compiler.internalError('currentBlock !== currentGraph.entry',
+                             instruction: node);
     }
     assert(dominated[0] == currentBlock.successors[0]);
     visitBasicBlock(dominated[0]);
   }
 
   // Used to write the name of labels.
   void writeLabel(LabelElement label) {
     buffer.add('\$${label.labelName}\$${label.target.nestingLevel}');
   }
 
@@ skipping 54 matching lines @@
       if (!tryCallAction(continueAction, target)) {
         addIndented("continue;\n");
       }
     }
   }
 
   visitTry(HTry node) {
     // We should never get here. Try/catch/finally is always handled using block
     // information in [visitTryInfo], or not at all, in the case of the bailout
     // generator.
-    unreachable();
+    compiler.internalError('visitTry should not be called', instruction: node);
   }
 
   visitIf(HIf node) {
     if (subGraph !== null && node.block === subGraph.end) {
       if (isGeneratingExpression()) {
         use(node.inputs[0], JSPrecedence.EXPRESSION_PRECEDENCE);
       }
       return;
     }
     HInstruction condition = node.inputs[0];
@@ skipping 907 matching lines @@
     } else if (node.isIndexablePrimitive()) {
       buffer.add('if (');
       checkString(input, '!==');
       buffer.add(' && (');
       checkObject(input, '!==');
       buffer.add('||');
       checkArray(input, '!==');
       buffer.add(')) ');
       bailout(node, 'Not a string or array');
     } else {
-      unreachable();
+      compiler.internalError('Unexpected type guard', instruction: input);
     }
     buffer.add(';\n');
   }
 
   void beginLoop(HBasicBlock block) {
     addIndentation();
     HLoopInformation info = block.loopInformation;
     for (LabelElement label in info.labels) {
       writeLabel(label);
       buffer.add(":");
@@ skipping 283 matching lines @@
       startBailoutSwitch();
     }
   }
 
   void endLabeledBlock(HLabeledBlockInformation labeledBlockInfo) {
     if (labeledBlockInfo.body.start.hasGuards()) {
       endBailoutSwitch();
     }
   }
 }