Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5033)

Unified Diff: chrome/common/extensions/extension_permission_set.h

Issue 10389137: Coverity: Fix pass by value error. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/common/extensions/extension_permission_set.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/extension_permission_set.h
diff --git a/chrome/common/extensions/extension_permission_set.h b/chrome/common/extensions/extension_permission_set.h
index 954c0ca39331ef2a5b8ce0de92912a8beeca90be..f366feed603c8b25e4b55077fd0b13a13f4e59ca 100644
--- a/chrome/common/extensions/extension_permission_set.h
+++ b/chrome/common/extensions/extension_permission_set.h
@@ -231,7 +231,7 @@ class ExtensionPermissionsInfo {
// Returns the permission with the given |name|, and NULL if none
// exists.
- ExtensionAPIPermission* GetByName(std::string name);
+ ExtensionAPIPermission* GetByName(const std::string& name);
// Returns a set containing all valid api permission ids.
ExtensionAPIPermissionSet GetAll();
« no previous file with comments | « no previous file | chrome/common/extensions/extension_permission_set.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698