Issue 10389125: Refactor StreamParser creation & enforce configs matching expected stream types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10389125: Refactor StreamParser creation & enforce configs matching expected stream types. (Closed)

Created:
8 years, 7 months ago by acolwell GONE FROM CHROMIUM

Modified:
8 years, 7 months ago

Reviewers:
vrk (LEFT CHROMIUM)

CC:
chromium-reviews, feature-media-reviews_chromium.org, annacc

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Refactor StreamParser creation & enforce configs matching expected stream types. BUG=122909 TEST=ChunkDemuxer.TestAVHeadersWithAudioOnlyType, ChunkDemuxer.TestAVHeadersWithVideoOnlyType Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137222

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+138 lines, -22 lines)			Patch
M	media/filters/chunk_demuxer.cc	View	1 2	5 chunks	+97 lines, -19 lines	0 comments	Download
M	media/filters/chunk_demuxer_unittest.cc	View		1 chunk	+28 lines, -0 lines	0 comments	Download
M	media/filters/source_buffer.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	media/filters/source_buffer.cc	View		3 chunks	+11 lines, -2 lines	0 comments	Download

Total messages: 5 (0 generated)

acolwell GONE FROM CHROMIUM

Moving StreamParser creation so that it is easier to add alternate parsers. Adding code to ...

8 years, 7 months ago (2012-05-14 18:50:59 UTC) #1

acolwell GONE FROM CHROMIUM

minor update that adds a factory function so that parser creation is driven from the ...

8 years, 7 months ago (2012-05-14 20:00:10 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acolwell@chromium.org/10389125/11002

8 years, 7 months ago (2012-05-15 16:48:13 UTC) #4

Change committed as 137222