Issue 10389111: Convert the remaining plugin_tests from ui_tests to browser_tests. Also remove the remaining refere…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10389111: Convert the remaining plugin_tests from ui_tests to browser_tests. Also remove the remaining refere… (Closed)

Created:
8 years, 7 months ago by jam

Modified:
8 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, stuartmorgan+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Convert the remaining plugin_tests from ui_tests to browser_tests. Also remove the remaining references to ui_tests and plugin_tests from gypi files. BUG=121574 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137010

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+156 lines, -315 lines)			Patch
M	build/all.gyp	View		3 chunks	+0 lines, -3 lines	0 comments	Download
D	chrome/browser/plugin_test.cc	View		1 chunk	+0 lines, -207 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View		2 chunks	+0 lines, -66 lines	0 comments	Download
M	chrome/test/data/npapi/layout_test_plugin.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/data/simple.html	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	content/browser/plugin_browsertest.cc	View	1	15 chunks	+154 lines, -38 lines	0 comments	Download

Total messages: 4 (0 generated)

jam

Don't run if the test data isn't there (since it's not public)

8 years, 7 months ago (2012-05-14 14:59:11 UTC) #1

jam

This will fail on bots until I update chrome/test/data/plugin which is in chrome-internal. I'll commit ...

8 years, 7 months ago (2012-05-14 16:26:07 UTC) #2

lgtm