Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10389109: Add gfx::Screen::IsEnabled() (Closed)

Created:
8 years, 7 months ago by pkotwicz
Modified:
8 years, 7 months ago
Reviewers:
oshima, sky
CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, ben+watch_chromium.org, tfarina, penghuang+watch_chromium.org, dcheng, James Su, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org
Visibility:
Public.

Description

Add gfx::Screen::IsEnabled(). This is useful for cross platform code and is required for 10391074

Patch Set 1 #

Total comments: 1

Patch Set 2 : Change as requested #

Patch Set 3 : Synced #

Patch Set 4 : Nicer diff #

Total comments: 1

Patch Set 5 : Rebased #

Patch Set 6 : Decided that the original approach with gfx::Sceren::IsDIPEnabled is better than the ifdef #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -5 lines) Patch
M ui/base/resource/resource_bundle.cc View 1 2 3 4 5 2 chunks +6 lines, -5 lines 0 comments Download
M ui/gfx/screen.h View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
M ui/gfx/screen_android.cc View 1 5 1 chunk +5 lines, -0 lines 0 comments Download
M ui/gfx/screen_aura.cc View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M ui/gfx/screen_gtk.cc View 1 5 1 chunk +5 lines, -0 lines 0 comments Download
M ui/gfx/screen_mac.mm View 1 5 1 chunk +5 lines, -0 lines 0 comments Download
M ui/gfx/screen_win.cc View 1 5 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
pkotwicz
8 years, 7 months ago (2012-05-13 04:28:56 UTC) #1
pkotwicz
8 years, 7 months ago (2012-05-13 04:28:57 UTC) #2
sky
http://codereview.chromium.org/10389109/diff/1/ui/base/resource/resource_bundle.cc File ui/base/resource/resource_bundle.cc (right): http://codereview.chromium.org/10389109/diff/1/ui/base/resource/resource_bundle.cc#newcode245 ui/base/resource/resource_bundle.cc:245: if (ui::IsDIPEnabled()) Can we define this for all platforms ...
8 years, 7 months ago (2012-05-14 14:09:57 UTC) #3
pkotwicz
Added ::IsDIPEnabled to gfx::Screen such that it is cross platform
8 years, 7 months ago (2012-05-14 20:01:06 UTC) #4
sky
LGTM
8 years, 7 months ago (2012-05-14 21:02:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/10389109/6001
8 years, 7 months ago (2012-05-14 21:32:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/10389109/4004
8 years, 7 months ago (2012-05-16 23:20:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/10389109/13002
8 years, 7 months ago (2012-05-17 02:01:01 UTC) #8
commit-bot: I haz the power
Change committed as 137622
8 years, 7 months ago (2012-05-17 03:17:51 UTC) #9
oshima
https://chromiumcodereview.appspot.com/10389109/diff/13002/ui/gfx/screen_aura.cc File ui/gfx/screen_aura.cc (right): https://chromiumcodereview.appspot.com/10389109/diff/13002/ui/gfx/screen_aura.cc#newcode32 ui/gfx/screen_aura.cc:32: return ui::IsDIPEnabled(); DIP is always enabled on aura now. ...
8 years, 7 months ago (2012-05-17 15:18:40 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/10389109/16003
8 years, 7 months ago (2012-05-17 16:31:06 UTC) #11
commit-bot: I haz the power
Change committed as 137684
8 years, 7 months ago (2012-05-17 18:00:53 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/10389109/18001
8 years, 7 months ago (2012-05-22 15:38:32 UTC) #13
commit-bot: I haz the power
Try job failure for 10389109-18001 (retry) on linux_chromeos for step "compile" (clobber build). It's a ...
8 years, 7 months ago (2012-05-22 16:07:11 UTC) #14
commit-bot: I haz the power
8 years, 7 months ago (2012-05-22 16:52:05 UTC) #15

Powered by Google App Engine
This is Rietveld 408576698