Implement GL_EXT_occlusion_query_boolean on OSX

Implement GL_EXT_occlusion_query_boolean on OSX

Stupid me, I assumed GL_ARB_occlusion_query2 was available
everywhere but it's not. So, if GL_ARB_occlusion_query2 is
not available fallback to GL_ARB_occlusion_query

TEST=unit tests
BUG=126592
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=136936

[greggman, 2012-05-12 00:25:19]

Hi Mo, Here's yet another.

[Zhenyao Mo, 2012-05-14 17:08:24]

On 2012/05/12 00:25:19, greggman wrote:
> Hi Mo, Here's yet another.

LGTM

[commit-bot: I haz the power, 2012-05-14 17:19:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gman@chromium.org/10389107/1

[commit-bot: I haz the power, 2012-05-14 19:24:16]

Change committed as 136936

[Nico, 2014-01-08 04:17:08]

https://chromiumcodereview.appspot.com/10389107/diff/1/gpu/command_buffer/ser...
File gpu/command_buffer/service/query_manager.cc (right):

https://chromiumcodereview.appspot.com/10389107/diff/1/gpu/command_buffer/ser...
gpu/command_buffer/service/query_manager.cc:70: return MarkAsCompleted(result !=
0);
Why this change? Should MarkAsCompleted() get a bool parameter instead?

[Zhenyao Mo, 2014-01-08 18:55:11]

https://chromiumcodereview.appspot.com/10389107/diff/1/gpu/command_buffer/ser...
File gpu/command_buffer/service/query_manager.cc (right):

https://chromiumcodereview.appspot.com/10389107/diff/1/gpu/command_buffer/ser...
gpu/command_buffer/service/query_manager.cc:70: return MarkAsCompleted(result !=
0);
On 2014/01/08 04:17:09, Nico wrote:
> Why this change? Should MarkAsCompleted() get a bool parameter instead?

This should actually be MarkAsCompleted(result == 0 ? 0 : 1)

[Nico, 2014-01-08 18:55:57]

On Wed, Jan 8, 2014 at 10:55 AM, <zmo@chromium.org> wrote:

>
> https://chromiumcodereview.appspot.com/10389107/diff/1/
> gpu/command_buffer/service/query_manager.cc
> File gpu/command_buffer/service/query_manager.cc (right):
>
> https://chromiumcodereview.appspot.com/10389107/diff/1/
> gpu/command_buffer/service/query_manager.cc#newcode70
> gpu/command_buffer/service/query_manager.cc:70: return
> MarkAsCompleted(result != 0);
> On 2014/01/08 04:17:09, Nico wrote:
>
>> Why this change? Should MarkAsCompleted() get a bool parameter
>>
> instead?
>
> This should actually be MarkAsCompleted(result == 0 ? 0 : 1)
>

What does MarkAsCompleted()s parameter mean? Is it always 0 or 1?


>
> https://chromiumcodereview.appspot.com/10389107/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Zhenyao Mo, 2014-01-08 19:08:17]

https://chromiumcodereview.appspot.com/10389107/diff/1/gpu/command_buffer/ser...
File gpu/command_buffer/service/query_manager.cc (right):

https://chromiumcodereview.appspot.com/10389107/diff/1/gpu/command_buffer/ser...
gpu/command_buffer/service/query_manager.cc:70: return MarkAsCompleted(result !=
0);
On 2014/01/08 18:55:11, Zhenyao Mo wrote:
> On 2014/01/08 04:17:09, Nico wrote:
> > Why this change? Should MarkAsCompleted() get a bool parameter instead?
> 
> This should actually be MarkAsCompleted(result == 0 ? 0 : 1)

If I understand this correctly (without going through all the details), in
general the query returns the number of pixels that a draw touched, but for this
extension GL_EXT_occlusion_query_boolean emulation, we only want true or false.