Issue 10389096: Adding libusb as a direct dependency of browser_extensions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10389096: Adding libusb as a direct dependency of browser_extensions. (Closed)

Created:
8 years, 7 months ago by Garret Kelly

Modified:
8 years, 7 months ago

Reviewers:
sadrul

CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Adding libusb as a direct dependency of browser_extensions. As reported by the Gentoo packagers in https://bugs.gentoo.org/413251 the USE_SYSTEM_LIBUSB define doesn't get set when UsbDeviceResource is compiled as part of the browser extensions. BUG=124803 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=136946

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	chrome/chrome_browser_extensions.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gdk@chromium.org/10389096/1

8 years, 7 months ago (2012-05-11 16:02:55 UTC) #2

commit-bot: I haz the power

Try job failure for 10389096-1 (retry) on win_rel for step "browser_tests". It's a second try, ...

8 years, 7 months ago (2012-05-11 19:02:36 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gdk@chromium.org/10389096/1

8 years, 7 months ago (2012-05-14 17:42:28 UTC) #4

Change committed as 136946