BinaryValue does not support NULL buffer.

base/values.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file specifies a recursive data storage class called Value intended for
 // storing setting and other persistable data.  It includes the ability to
 // specify (recursive) lists and dictionaries, so it's fairly expressive.
 // However, the API is optimized for the common case, namely storing a
 // hierarchical tree of simple values.  Given a DictionaryValue root, you can
 // easily do things like:
@@ skipping 12 matching lines @@
 #pragma once
 
 #include <iterator>
 #include <map>
 #include <string>
 #include <vector>
 
 #include "base/base_export.h"
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
+#include "base/memory/scoped_ptr.h"
 #include "base/string16.h"
 
 // This file declares "using base::Value", etc. at the bottom, so that
 // current code can use these classes without the base namespace. In
 // new code, please always use base::Value, etc. or add your own
 // "using" declaration.
 // http://crbug.com/88666
 namespace base {
 
 class BinaryValue;
@@ skipping 127 matching lines @@
   virtual bool Equals(const Value* other) const OVERRIDE;
 
  private:
   std::string value_;
 
   DISALLOW_COPY_AND_ASSIGN(StringValue);
 };
 
 class BASE_EXPORT BinaryValue: public Value {
  public:
-  virtual ~BinaryValue();
-
-  // Creates a Value to represent a binary buffer.  The new object takes
-  // ownership of the pointer passed in, if successful.
-  // Returns NULL if buffer is NULL.
-  static BinaryValue* Create(char* buffer, size_t size);
+  // Creates a BinaryValue with a NULL buffer and size of 0.
+  BinaryValue();
+  BinaryValue(scoped_ptr<char> buffer, size_t size);

[asargent_no_longer_on_chrome, 2012/05/18 22:49:49]

nit: it might be worth adding a comment above this second constructor -
something along the lines of "Creates a BinaryValue, taking ownership of the
bytes pointed to by |buffer|".

[mitchellwrosen, 2012/05/18 23:04:29]

Done.

 
   // For situations where you want to keep ownership of your buffer, this
   // factory method creates a new BinaryValue by copying the contents of the
   // buffer that's passed in.
-  // Returns NULL if buffer is NULL.
   static BinaryValue* CreateWithCopiedBuffer(const char* buffer, size_t size);
 
   size_t GetSize() const { return size_; }
-  char* GetBuffer() { return buffer_; }
-  const char* GetBuffer() const { return buffer_; }
+
+  // May return NULL.
+  char* GetBuffer() { return buffer_.get(); }
+  const char* GetBuffer() const { return buffer_.get(); }
 
   // Overridden from Value:
   virtual BinaryValue* DeepCopy() const OVERRIDE;
   virtual bool Equals(const Value* other) const OVERRIDE;
 
  private:
-  // Constructor is private so that only objects with valid buffer pointers
-  // and size values can be created.
-  BinaryValue(char* buffer, size_t size);
-
-  char* buffer_;
+  scoped_ptr<char> buffer_;
   size_t size_;
 
   DISALLOW_COPY_AND_ASSIGN(BinaryValue);
 };
 
 // DictionaryValue provides a key-value dictionary with (optional) "path"
 // parsing for recursive access; see the comment at the top of the file. Keys
 // are |std::string|s and should be UTF-8 encoded.
 class BASE_EXPORT DictionaryValue : public Value {
  public:
@@ skipping 272 matching lines @@
 
 }  // namespace base
 
 // http://crbug.com/88666
 using base::DictionaryValue;
 using base::ListValue;
 using base::StringValue;
 using base::Value;
 
 #endif  // BASE_VALUES_H_