Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 10389062: Progagate variable android_upstream_bringup to right scope. (Closed)

Created:
8 years, 7 months ago by Johnny(Jianning) Ding
Modified:
8 years, 7 months ago
Reviewers:
John Grabowski
CC:
chromium-reviews
Visibility:
Public.

Description

Progagate variable android_upstream_bringup to right scope. Need to propagate variable android_upstream_bringup to outer variable dict to make sure the variable can be reached by condition ['android_upstream_bringup==1' even we are in downstream tree which doesn't define android_upstream_bringup=1. Otherwise android-gyp is going to show "NameError: name 'android_upstream_bringup' is not defined while evaluating condition 'android_upstream_bringup==1' in /usr/local/google/code/chromium-android/src/build/all_android.gyp..." BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=136515

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M build/common.gypi View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Johnny(Jianning) Ding
8 years, 7 months ago (2012-05-10 08:54:54 UTC) #1
John Grabowski
LGTM Thx for the follow-up
8 years, 7 months ago (2012-05-10 15:01:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jnd@chromium.org/10389062/1
8 years, 7 months ago (2012-05-11 04:21:38 UTC) #3
commit-bot: I haz the power
8 years, 7 months ago (2012-05-11 05:42:37 UTC) #4
Change committed as 136515

Powered by Google App Engine
This is Rietveld 408576698