mac: Don't require DYLD_LIBRARY_PATH to be set when using the shared build.

mac: Don't require DYLD_LIBRARY_PATH to be set when using the shared build.

Set the install name of all dylibs to @rpath.

Set the rpath of all executables to '@loader_path/.' (for normal binaries)
and '@loader_path/../../..' (for bundled binaries).

Also, Chromium Helper.app doesn't end up in out/Release but
somewhere below Chromium.app, so set its rpath to
'@loader_path/../../../../../../..' to get all the way back to
out/Release.

Also add "(allow file-read-metadata)" to the sandbox definition when
running on 10.6 or earlier when using the component build, to work
around a bug in dyld (see http://crbug.com/127465).

BUG=90078, 127465
TEST=Do a components build. DYLD_LIBRARY_PATH isn't necessary at
build time, and isn't necessary when running chromium or test binaries.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=139550

[Nico, 2012-05-30 04:38:26]

This is the last missing piece for the mac components build, as far as I know.

[Mark Mentovai, 2012-05-30 13:38:22]

LG otherwise

http://codereview.chromium.org/10389047/diff/3007/build/common.gypi
File build/common.gypi (right):

http://codereview.chromium.org/10389047/diff/3007/build/common.gypi#newcode1281
build/common.gypi:1281: '@loader_path/.',
Just '@loader_path' without the extra '/.' should work here. Does it?

http://codereview.chromium.org/10389047/diff/3007/content/common/sandbox_mac.mm
File content/common/sandbox_mac.mm (right):

http://codereview.chromium.org/10389047/diff/3007/content/common/sandbox_mac....
content/common/sandbox_mac.mm:383: NSString* common_sandbox_prefix_data =
I’m leery of taking this out of the scoped_nsobject that it had been in, since I
can’t easily see the autorelease pool that surrounds this, and it might just be
the big early-startup one.

[Nico, 2012-05-30 15:03:29]

http://codereview.chromium.org/10389047/diff/3007/build/common.gypi
File build/common.gypi (right):

http://codereview.chromium.org/10389047/diff/3007/build/common.gypi#newcode1281
build/common.gypi:1281: '@loader_path/.',
On 2012/05/30 13:38:22, Mark Mentovai wrote:
> Just '@loader_path' without the extra '/.' should work here. Does it?

No, dyld looks for "@loader_path/" with the slash. See
ImageLoaderMachO::getRPaths() in dyld's ImageLoaderMachO.cpp. `man dyld` also
hints at the slash being required, but not in the most explicit way. (Maybe I
could drop just the '.', but that looks strange.)

http://codereview.chromium.org/10389047/diff/3007/content/common/sandbox_mac.mm
File content/common/sandbox_mac.mm (right):

http://codereview.chromium.org/10389047/diff/3007/content/common/sandbox_mac....
content/common/sandbox_mac.mm:383: NSString* common_sandbox_prefix_data =
On 2012/05/30 13:38:22, Mark Mentovai wrote:
> I’m leery of taking this out of the scoped_nsobject that it had been in, since
I
> can’t easily see the autorelease pool that surrounds this, and it might just
be
> the big early-startup one. 

Done.

[Mark Mentovai, 2012-05-30 15:27:48]

LGTM

[Nico, 2012-05-30 15:29:39]

thanks!

[commit-bot: I haz the power, 2012-05-30 15:36:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/10389047/6009

[commit-bot: I haz the power, 2012-05-30 15:36:46]

Presubmit check for 10389047-6009 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    content/common

[jeremy, 2012-05-30 16:33:16]

https://chromiumcodereview.appspot.com/10389047/diff/6009/content/common/sand...
File content/common/sandbox_mac.mm (right):

https://chromiumcodereview.appspot.com/10389047/diff/6009/content/common/sand...
content/common/sandbox_mac.mm:394: stringByAppendingString:@"\n(allow
file-read-metadata)\n"];
Please move these lines to the Sandbox definition file together with a
;SOME_PREFIX which is then removed in component builds.  The rationale for this
is so it would be easy to see the whole sandbox definition in one place.

Also, is there a way we can limit this rule to just a specific subpath rather
than allowing global filesystem access?

[Nico, 2012-05-30 16:38:33]

https://chromiumcodereview.appspot.com/10389047/diff/6009/content/common/sand...
File content/common/sandbox_mac.mm (right):

https://chromiumcodereview.appspot.com/10389047/diff/6009/content/common/sand...
content/common/sandbox_mac.mm:394: stringByAppendingString:@"\n(allow
file-read-metadata)\n"];
On 2012/05/30 16:33:17, jeremy wrote:
> Please move these lines to the Sandbox definition file together with a
> ;SOME_PREFIX which is then removed in component builds.  The rationale for
this
> is so it would be easy to see the whole sandbox definition in one place.
> 
> Also, is there a way we can limit this rule to just a specific subpath rather
> than allowing global filesystem access?

See bug, it needs file-read-metadata for the currently running binary. But since
this is just used with COMPONENT_BUILD set and running on 10.6, I figured
keeping things simple is the appropriate thing to do.