Fixed compilation time measurement, restructure some code.

runtime/vm/code_generator_ia32.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_CODE_GENERATOR_IA32_H_
 #define VM_CODE_GENERATOR_IA32_H_
 
 #ifndef VM_CODE_GENERATOR_H_
 #error Do not include code_generator_ia32.h directly; use code_generator.h.
 #endif
@@ skipping 59 matching lines @@
   CodeGenerator(Assembler* assembler, const ParsedFunction& parsed_function);
   virtual ~CodeGenerator() { }
 
   // Accessors.
   Assembler* assembler() const { return assembler_; }
 
   const ParsedFunction& parsed_function() const { return parsed_function_; }
 
   void GenerateCode();
   virtual void GenerateDeferredCode();
+  virtual void InitGenerator();

[regis, 2012/05/08 21:26:41]

Add comment explaining why you factorize this initialization out of the
constructor.

[srdjan, 2012/05/08 21:43:18]

  // Constructor is lighweight, major initialization work should occur here.
  // This makes it easier to measure time spent in the code generator.

 
 #define DEFINE_VISITOR_FUNCTION(type, name)                                    \
   virtual void Visit##type(type* node);
 NODE_LIST(DEFINE_VISITOR_FUNCTION)
 #undef DEFINE_VISITOR_FUNCTION
 
   CodeGeneratorState* state() const { return state_; }
   void set_state(CodeGeneratorState* state) { state_ = state; }
 
   // Add exception handler table to code.
@@ skipping 166 matching lines @@
   // The runtime context level is only incremented when a new context is
   // allocated and chained to the list of contexts.
   intptr_t context_level_;
 
   DISALLOW_IMPLICIT_CONSTRUCTORS(CodeGenerator);
 };
 
 }  // namespace dart
 
 #endif  // VM_CODE_GENERATOR_IA32_H_