Fixed compilation time measurement, restructure some code.

runtime/vm/object.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/object.h"
 
 #include "platform/assert.h"
 #include "vm/assembler.h"
 #include "vm/bigint_operations.h"
 #include "vm/bootstrap.h"
@@ skipping 6069 matching lines @@
   Instructions& instrs =
       Instructions::ZoneHandle(Instructions::New(assembler->CodeSize(), space));
 
   // Copy the instructions into the instruction area and apply all fixups.
   // Embedded pointers are still in handles at this point.
   MemoryRegion region(reinterpret_cast<void*>(instrs.EntryPoint()),
                       instrs.size());
   assembler->FinalizeInstructions(region);
   DebugInfo* pprof_symbol_generator = Dart::pprof_symbol_generator();
   if (pprof_symbol_generator != NULL) {
+    ASSERT(strlen(name) != 0);
     pprof_symbol_generator->AddCode(instrs.EntryPoint(), instrs.size());
     pprof_symbol_generator->AddCodeRegion(name,
                                           instrs.EntryPoint(),
                                           instrs.size());
   }
   if (FLAG_generate_gdb_symbols) {
+    ASSERT(strlen(name) != 0);
     intptr_t prolog_offset = assembler->prolog_offset();
     if (prolog_offset > 0) {
       // In order to ensure that gdb sees the first instruction of a function
       // as the prolog sequence we register two symbols for the cases when
       // the prolog sequence is not the first instruction:
       // <name>_entry is used for code preceding the prolog sequence.
       // <name> for rest of the code (first instruction is prolog sequence).
       const char* kFormat = "%s_%s";
       intptr_t len = OS::SNPrint(NULL, 0, kFormat, name, "entry");
       char* pname = reinterpret_cast<char*>(
@@ skipping 27 matching lines @@
     }
 
     // Hook up Code and Instruction objects.
     instrs.set_code(code.raw());
     code.set_instructions(instrs.raw());
   }
   return code.raw();
 }
 
 
-RawCode* Code::FinalizeCode(const char* name, Assembler* assembler) {
-  return FinalizeCode(name, assembler, Heap::kDartCode);
+RawCode* Code::FinalizeCode(const Function& function, Assembler* assembler) {
+  // Calling ToFullyQualifiedCString is very expensive, try to avoid it.
+  if (FLAG_generate_gdb_symbols || (Dart::pprof_symbol_generator() != NULL)) {
+    return FinalizeCode(function.ToFullyQualifiedCString(),
+                        assembler,
+                        Heap::kDartCode);
+  } else {
+    return FinalizeCode("", assembler, Heap::kDartCode);
+  }
 }
 
 
 RawCode* Code::FinalizeStubCode(const char* name, Assembler* assembler) {
   return FinalizeCode(name, assembler, Heap::kStubCode);
 }
 
 
 intptr_t Code::GetTokenIndexOfPC(uword pc) const {
   intptr_t token_index = -1;
@@ skipping 3729 matching lines @@
   const String& str = String::Handle(pattern());
   const char* format = "JSRegExp: pattern=%s flags=%s";
   intptr_t len = OS::SNPrint(NULL, 0, format, str.ToCString(), Flags());
   char* chars = reinterpret_cast<char*>(
       Isolate::Current()->current_zone()->Allocate(len + 1));
   OS::SNPrint(chars, (len + 1), format, str.ToCString(), Flags());
   return chars;
 }
 
 }  // namespace dart