Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: chrome/browser/extensions/webstore_inline_installer.cc

Issue 10388252: Refactoring ExtenionInstallUI to abstract the Browser references. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Synced + mac fix Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/webstore_inline_installer.cc
diff --git a/chrome/browser/extensions/webstore_inline_installer.cc b/chrome/browser/extensions/webstore_inline_installer.cc
index 9155f3f9a63f2e394d561ea91e428137b5e5b2a9..8d085e8c256f8030b3271e374391f111ab60cbab 100644
--- a/chrome/browser/extensions/webstore_inline_installer.cc
+++ b/chrome/browser/extensions/webstore_inline_installer.cc
@@ -260,8 +260,8 @@ void WebstoreInlineInstaller::OnWebstoreResponseParseSuccess(
return;
}
- if (average_rating_ < ExtensionInstallUI::kMinExtensionRating ||
- average_rating_ >ExtensionInstallUI::kMaxExtensionRating) {
+ if (average_rating_ < ExtensionInstallPrompt::kMinExtensionRating ||
+ average_rating_ > ExtensionInstallPrompt::kMaxExtensionRating) {
CompleteInstall(kInvalidWebstoreResponseError);
return;
}
@@ -344,12 +344,13 @@ void WebstoreInlineInstaller::OnWebstoreParseSuccess(
Profile* profile = Profile::FromBrowserContext(
web_contents()->GetBrowserContext());
- ExtensionInstallUI::Prompt prompt(ExtensionInstallUI::INLINE_INSTALL_PROMPT);
+ ExtensionInstallPrompt::Prompt prompt(
+ ExtensionInstallPrompt::INLINE_INSTALL_PROMPT);
prompt.SetInlineInstallWebstoreData(localized_user_count_,
average_rating_,
rating_count_);
std::string error;
- dummy_extension_ = ExtensionInstallUI::GetLocalizedExtensionForDisplay(
+ dummy_extension_ = ExtensionInstallPrompt::GetLocalizedExtensionForDisplay(
manifest, id_, localized_name_, localized_description_, &error);
if (!dummy_extension_) {
OnWebstoreParseFailure(id_, WebstoreInstallHelper::Delegate::MANIFEST_ERROR,
@@ -357,7 +358,7 @@ void WebstoreInlineInstaller::OnWebstoreParseSuccess(
return;
}
- install_ui_.reset(new ExtensionInstallUI(profile));
+ install_ui_.reset(new ExtensionInstallPrompt(profile));
install_ui_->ConfirmInlineInstall(this, dummy_extension_, &icon_, prompt);
// Control flow finishes up in InstallUIProceed or InstallUIAbort.
}
« no previous file with comments | « chrome/browser/extensions/webstore_inline_installer.h ('k') | chrome/browser/infobars/infobars_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698