Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1586)

Unified Diff: chrome/browser/automation/testing_automation_provider.cc

Issue 10388252: Refactoring ExtenionInstallUI to abstract the Browser references. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Minor clean-ups Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/automation/testing_automation_provider.cc
diff --git a/chrome/browser/automation/testing_automation_provider.cc b/chrome/browser/automation/testing_automation_provider.cc
index 8480c30c75864fe258882f2e174fa49b1ebb86c0..e7c5661fdb6456f5bf1aa541c034d8c29bc44b0e 100644
--- a/chrome/browser/automation/testing_automation_provider.cc
+++ b/chrome/browser/automation/testing_automation_provider.cc
@@ -3901,7 +3901,8 @@ void TestingAutomationProvider::GetThemeInfo(
DictionaryValue* args,
IPC::Message* reply_message) {
scoped_ptr<DictionaryValue> return_value(new DictionaryValue);
- const Extension* theme = ThemeServiceFactory::GetThemeForProfile(profile());
+ const Extension* theme =
Yoyo Zhou 2012/05/23 23:17:49 nit: This change looks spurious.
Jay Civelli 2012/05/30 20:20:35 Done.
+ ThemeServiceFactory::GetThemeForProfile(profile());
if (theme) {
return_value->SetString("name", theme->name());
return_value->Set("images", theme->GetThemeImages()->DeepCopy());
@@ -3946,8 +3947,8 @@ void TestingAutomationProvider::InstallExtension(
// If the given path has a 'crx' extension, assume it is a packed extension
// and install it. Otherwise load it as an unpacked extension.
if (extension_path.MatchesExtension(FILE_PATH_LITERAL(".crx"))) {
- ExtensionInstallUI* client =
- (with_ui ? new ExtensionInstallUI(browser->profile()) : NULL);
+ ExtensionInstallPrompt* client =
+ (with_ui ? new ExtensionInstallPrompt(browser->profile()) : NULL);
scoped_refptr<CrxInstaller> installer(
CrxInstaller::Create(service, client));
if (!with_ui)
« no previous file with comments | « no previous file | chrome/browser/chromeos/extensions/file_manager_util.cc » ('j') | chrome/browser/download/download_crx_util.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698