Replace most users of BrowserList::GetLastActive in feedback ui with more appropriate functions.

Replace most users of BrowserList::GetLastActive in feedback ui with more appropriate functions.

http://crbug.com/129187
TEST=none
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138317

[Evan Stade, 2012-05-22 18:46:11]

lgtm

http://codereview.chromium.org/10388232/diff/1/chrome/browser/ui/webui/feedba...
File chrome/browser/ui/webui/feedback_ui.cc (right):

http://codereview.chromium.org/10388232/diff/1/chrome/browser/ui/webui/feedba...
chrome/browser/ui/webui/feedback_ui.cc:382: SetupScreenshotsSource();
I have no idea why this is called twice

[Ben Goodger (Google), 2012-05-22 19:21:27]

http://codereview.chromium.org/10388232/diff/1/chrome/browser/ui/webui/feedba...
File chrome/browser/ui/webui/feedback_ui.cc (right):

http://codereview.chromium.org/10388232/diff/1/chrome/browser/ui/webui/feedba...
chrome/browser/ui/webui/feedback_ui.cc:382: SetupScreenshotsSource();
On 2012/05/22 18:46:11, Evan Stade wrote:
> I have no idea why this is called twice

Initial inspection seems to suggest that via Init(), it is only called if the
tab index is valid. It won't be called if it's invalid, but even if it is
invalid, construction of the FeedbackUI continues (false is passed to
CreateFeedbackUIHTMLSource instead). RegisterMessages() appears to be some sort
of framework function, which will probably end up being called later, so it
seems this code has another stab at initializing the source if it wasn't done
already.

It could be that we want this setup done regardless of whether or not the index
supplied is valid. I don't know any of this code well enough to say what
expectation is/what's the right thing to do.