Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 10388230: Allow Control+Shift+Q on lock screen. (Closed)

Created:
8 years, 7 months ago by Yusuke Sato
Modified:
8 years, 7 months ago
Reviewers:
Daniel Erat
CC:
chromium-reviews, mazda+watch_chromium.org, sadrul, derat+watch_chromium.org, ben+watch_chromium.org, pkotwicz
Visibility:
Public.

Description

Allow Control+Shift+Q on lock screen. Usually, when the screen is locked and the status area at the bottom right corner of the screen is not focused, Control+Shift+Q is handled by chrome/browser/chromeos/login/webui_login_view.cc. But when the status area is focused, Control+Shift+Q is handled by Ash, accelerator_controller.cc. BUG=120953 TEST=aura_shell_unittests + manual: focus the area and press C+S+Q on both login and lock screens Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=138509

Patch Set 1 #

Patch Set 2 : review #

Total comments: 2

Patch Set 3 : fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -18 lines) Patch
M ash/accelerators/accelerator_controller.h View 1 1 chunk +3 lines, -1 line 0 comments Download
M ash/accelerators/accelerator_controller.cc View 1 2 chunks +17 lines, -7 lines 0 comments Download
M ash/accelerators/accelerator_table.h View 1 2 1 chunk +10 lines, -3 lines 0 comments Download
M ash/accelerators/accelerator_table.cc View 1 2 chunks +10 lines, -3 lines 0 comments Download
M ash/accelerators/accelerator_table_unittest.cc View 1 1 chunk +8 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Yusuke Sato
8 years, 7 months ago (2012-05-23 05:39:42 UTC) #1
Daniel Erat
lgtm http://codereview.chromium.org/10388230/diff/3001/ash/accelerators/accelerator_table.h File ash/accelerators/accelerator_table.h (right): http://codereview.chromium.org/10388230/diff/3001/ash/accelerators/accelerator_table.h#newcode93 ash/accelerators/accelerator_table.h:93: // Actions allowed while user is locked. nit: ...
8 years, 7 months ago (2012-05-23 13:45:20 UTC) #2
Yusuke Sato
http://codereview.chromium.org/10388230/diff/3001/ash/accelerators/accelerator_table.h File ash/accelerators/accelerator_table.h (right): http://codereview.chromium.org/10388230/diff/3001/ash/accelerators/accelerator_table.h#newcode93 ash/accelerators/accelerator_table.h:93: // Actions allowed while user is locked. On 2012/05/23 ...
8 years, 7 months ago (2012-05-23 15:36:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusukes@chromium.org/10388230/2002
8 years, 7 months ago (2012-05-23 15:37:24 UTC) #4
commit-bot: I haz the power
8 years, 7 months ago (2012-05-23 17:17:05 UTC) #5
Change committed as 138509

Powered by Google App Engine
This is Rietveld 408576698