Issue 10388229: Install AshFocusManagerFactory before creating launcher, tray, wall paper and their views::FocusMan…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10388229: Install AshFocusManagerFactory before creating launcher, tray, wall paper and their views::FocusMan… (Closed)

Created:
8 years, 7 months ago by Yusuke Sato

Modified:
8 years, 7 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Install AshFocusManagerFactory before creating launcher, tray, wall paper and their views::FocusManagers. Otherwise, Ash shortcut keys cannot be used when either launcher or status area is focused. BUG=120953, 123856 TEST=crosbug.com/120953#c17 TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138450

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	ash/shell.cc	View		2 chunks	+4 lines, -2 lines	0 comments	Download

Total messages: 5 (0 generated)

Yusuke Sato

Got LGTM from Ben on Date: Tue, 22 May 2012 07:55:32 -0700 via e-mail, but ...

8 years, 7 months ago (2012-05-23 00:53:24 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusukes@chromium.org/10388229/1

8 years, 7 months ago (2012-05-23 00:54:26 UTC) #3

commit-bot: I haz the power

Try job failure for 10388229-1 (retry) (retry) on win_rel for step "sync_unit_tests". It's a second ...

8 years, 7 months ago (2012-05-23 07:00:38 UTC) #4

commit-bot: I haz the power

8 years, 7 months ago (2012-05-23 07:14:55 UTC) #5

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yusukes@chromium.org/10388229/1