Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(48)

Issue 10388226: This broke M20 build. (Closed)

Created:
8 years, 4 months ago by dharani
Modified:
8 years, 4 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

This broke M20 build. Revert 137824 - Properly handle accounts that don't have GMail account. 1. Me2MeHostAuthenticatorFactory now verifies that the bare JID of the remote client matches bare JID of the host. Previously it was comparing it with the user's email, which may be different from JID. 2. GaiaOAuthClient now fetches user's email. 3. SignalingConnector verifies that user's email matches the expected value stored in xmpp_login. If it doesn't, then the auth token was generated for a different account and the host treats it as an authentication error. BUG=128102 Review URL: https://chromiumcodereview.appspot.com/10332187 TBR=sergeyu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138204

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -129 lines) Patch
M remoting/host/gaia_oauth_client.h View 3 chunks +6 lines, -11 lines 0 comments Download
M remoting/host/gaia_oauth_client.cc View 5 chunks +26 lines, -84 lines 0 comments Download
M remoting/host/remoting_me2me_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/signaling_connector.h View 1 chunk +1 line, -2 lines 0 comments Download
M remoting/host/signaling_connector.cc View 2 chunks +2 lines, -12 lines 0 comments Download
M remoting/host/simple_host_process.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/jingle_glue/xmpp_signal_strategy.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M remoting/protocol/authenticator.h View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/protocol/fake_authenticator.h View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/protocol/fake_authenticator.cc View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/protocol/it2me_host_authenticator_factory.h View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/protocol/it2me_host_authenticator_factory.cc View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/protocol/jingle_session_manager.cc View 1 chunk +1 line, -2 lines 0 comments Download
M remoting/protocol/me2me_host_authenticator_factory.h View 2 chunks +1 line, -1 line 0 comments Download
M remoting/protocol/me2me_host_authenticator_factory.cc View 1 chunk +5 lines, -9 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
dharani
8 years, 4 months ago (2012-05-22 03:15:53 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698