Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 10388221: Revert 138168 - net: Fix a regression that broke file uploading with http authentication (Closed)

Created:
8 years, 7 months ago by Nicolas Zea
Modified:
8 years, 7 months ago
Reviewers:
satorux1
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Revert 138168 - net: Fix a regression that broke file uploading with http authentication Failing net_unit_tests RequestSocketsMultipleTimesDoesNothing. When uploading a file with http authentication, UploadData is reused for a new UploadDataStream. Hence, we should close the files in UploadData if already opened and read, so we can reread the files from the beginning. The regression was caused by r123677. Special thanks to thomas.themel for identifying the offending patch and helping us to fix the issue. BUG=128574 TEST=added a unit test; manually confirmed that uploading a file with basic authentication, and multi-round authentication with NTLM and Negotiate worked. Review URL: https://chromiumcodereview.appspot.com/10408042 TBR=satorux@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138175

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -60 lines) Patch
M net/base/upload_data.h View 1 chunk +2 lines, -3 lines 0 comments Download
M net/base/upload_data.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M net/base/upload_data_stream_unittest.cc View 2 chunks +0 lines, -43 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Nicolas Zea
8 years, 7 months ago (2012-05-22 00:01:54 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698