Issue 10388219: Fix keyboard shortcuts not working if a sad tab is focused.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10388219: Fix keyboard shortcuts not working if a sad tab is focused. (Closed)

Created:
8 years, 7 months ago by mazda

Modified:
8 years, 7 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch-content_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix keyboard shortcuts not working if a sad tab is focused. BUG=124072 TEST=Open chrome://crash, then checked shortcuts worked properly. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138298

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -1 line)			Patch
	M	content/browser/web_contents/web_contents_view_aura.cc	View		2 chunks	+7 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mazda@chromium.org/10388219/1

8 years, 7 months ago (2012-05-22 15:31:45 UTC) #3

commit-bot: I haz the power

Try job failure for 10388219-1 (retry) on linux_chromeos for step "compile" (clobber build). It's a ...

8 years, 7 months ago (2012-05-22 15:50:04 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mazda@chromium.org/10388219/1

8 years, 7 months ago (2012-05-22 16:22:43 UTC) #5

commit-bot: I haz the power

8 years, 7 months ago (2012-05-22 16:23:30 UTC) #6

Try job failure for 10388219-1 on mac_rel for step "update".
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

Expand Messages | Collapse Messages