Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 10388218: Allow for building content_shell from within WebKit (Closed)

Created:
8 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
8 years, 7 months ago
Reviewers:
jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, pam+watch_chromium.org, jochen+watch-content_chromium.org
Visibility:
Public.

Description

Allow for building content_shell from within WebKit BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138231

Patch Set 1 #

Total comments: 2

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -9 lines) Patch
M content/browser/debugger/devtools_resources.gyp View 1 chunk +10 lines, -1 line 0 comments Download
M content/content.gyp View 1 1 chunk +19 lines, -1 line 0 comments Download
M content/content_browser.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/content_common.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/content_renderer.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/content_shell.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/content_tests.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M content/content_worker.gypi View 1 chunk +1 line, -1 line 0 comments Download
M tools/gritsettings/resource_ids View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jochen (gone - plz use gerrit)
chromium side changes for building content_shell from within WebKit WebKit side is here: https://bugs.webkit.org/show_bug.cgi?id=87045 John, ...
8 years, 7 months ago (2012-05-21 21:38:34 UTC) #1
jam
https://chromiumcodereview.appspot.com/10388218/diff/1/content/content.gyp File content/content.gyp (right): https://chromiumcodereview.appspot.com/10388218/diff/1/content/content.gyp#newcode64 content/content.gyp:64: 'conditions': [ instead of duplicating this everywhere, can't we ...
8 years, 7 months ago (2012-05-21 21:44:10 UTC) #2
jochen (gone - plz use gerrit)
https://chromiumcodereview.appspot.com/10388218/diff/1/content/content.gyp File content/content.gyp (right): https://chromiumcodereview.appspot.com/10388218/diff/1/content/content.gyp#newcode64 content/content.gyp:64: 'conditions': [ On 2012/05/21 21:44:10, John Abd-El-Malek wrote: > ...
8 years, 7 months ago (2012-05-21 22:00:34 UTC) #3
jam
8 years, 7 months ago (2012-05-21 22:33:45 UTC) #4
lgtm!

Powered by Google App Engine
This is Rietveld 408576698