Users stuck in fullscreen mode when running gnome-shell.

Users stuck in fullscreen mode when running gnome-shell.

This fixes the bug by setting _GTK_HIDE_TITLEBAR_WHEN_MAXIMIZED
on the window, which causes mutter to not force fullscreen on the
window.

Owen suggested this work around.

BUG=114636
TEST=In gnome-shell, enable auto-hide panels, maximize a chrome window, then
  try toggling fullscreen on and off.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138357

[tony, 2012-05-21 21:24:04]

Reference to gnome-shell/mutter code:
http://git.gnome.org/browse/mutter/tree/src/core/constraints.c#n449

Reference to upstream bug:
https://bugzilla.gnome.org/show_bug.cgi?id=676521

[Daniel Erat, 2012-05-21 21:37:10]

https://chromiumcodereview.appspot.com/10388217/diff/1/chrome/browser/ui/gtk/...
File chrome/browser/ui/gtk/browser_window_gtk.cc (right):

https://chromiumcodereview.appspot.com/10388217/diff/1/chrome/browser/ui/gtk/...
chrome/browser/ui/gtk/browser_window_gtk.cc:434:
ui::SetHideTitlebarWhenMaximizedProperty(gtk_widget_get_window(
nit: mind moving "gtk_window_get_window(" down to the next line?  i find it a
bit easier to read that way.

https://chromiumcodereview.appspot.com/10388217/diff/1/ui/base/x/x11_util.h
File ui/base/x/x11_util.h (right):

https://chromiumcodereview.appspot.com/10388217/diff/1/ui/base/x/x11_util.h#n...
ui/base/x/x11_util.h:124: UI_EXPORT void
SetHideTitlebarWhenMaximizedProperty(GdkWindow* window);
despite the atom's name, this isn't really GTK-specific, is it?  could you make
it take an X window instead?

[tony, 2012-05-21 21:47:30]

https://chromiumcodereview.appspot.com/10388217/diff/1/chrome/browser/ui/gtk/...
File chrome/browser/ui/gtk/browser_window_gtk.cc (right):

https://chromiumcodereview.appspot.com/10388217/diff/1/chrome/browser/ui/gtk/...
chrome/browser/ui/gtk/browser_window_gtk.cc:434:
ui::SetHideTitlebarWhenMaximizedProperty(gtk_widget_get_window(
On 2012/05/21 21:37:10, Daniel Erat wrote:
> nit: mind moving "gtk_window_get_window(" down to the next line?  i find it a
> bit easier to read that way.

Done.

https://chromiumcodereview.appspot.com/10388217/diff/1/ui/base/x/x11_util.h
File ui/base/x/x11_util.h (right):

https://chromiumcodereview.appspot.com/10388217/diff/1/ui/base/x/x11_util.h#n...
ui/base/x/x11_util.h:124: UI_EXPORT void
SetHideTitlebarWhenMaximizedProperty(GdkWindow* window);
On 2012/05/21 21:37:10, Daniel Erat wrote:
> despite the atom's name, this isn't really GTK-specific, is it?  could you
make
> it take an X window instead?

Done.

[Daniel Erat, 2012-05-21 22:09:06]

lgtm

https://chromiumcodereview.appspot.com/10388217/diff/6002/ui/base/x/x11_util.h
File ui/base/x/x11_util.h (right):

https://chromiumcodereview.appspot.com/10388217/diff/6002/ui/base/x/x11_util....
ui/base/x/x11_util.h:124: UI_EXPORT void
SetHideTitlebarWhenMaximizedProperty(XID window);
nit: move this outside of TOOLKIT_GTK?

[tony, 2012-05-21 22:18:36]

estade?

On 2012/05/21 22:09:06, Daniel Erat wrote:
> https://chromiumcodereview.appspot.com/10388217/diff/6002/ui/base/x/x11_util.h
> File ui/base/x/x11_util.h (right):
> 
>
https://chromiumcodereview.appspot.com/10388217/diff/6002/ui/base/x/x11_util....
> ui/base/x/x11_util.h:124: UI_EXPORT void
> SetHideTitlebarWhenMaximizedProperty(XID window);
> nit: move this outside of TOOLKIT_GTK?

I originally didn't think this was going to be used by outside of toolkit_gtk,
but actually, we probably will need this.

[Evan Stade, 2012-05-22 01:17:13]

lgtm

[commit-bot: I haz the power, 2012-05-22 16:31:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tony@chromium.org/10388217/9002

[commit-bot: I haz the power, 2012-05-22 17:48:25]

Try job failure for 10388217-9002 (retry) on win for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

[commit-bot: I haz the power, 2012-05-22 17:55:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tony@chromium.org/10388217/9002

[commit-bot: I haz the power, 2012-05-22 18:46:42]

Try job failure for 10388217-9002 (retry) on win for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...