Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 10388215: replace prep_libc.sh with prep_libc.py, and quiet the output (Closed)

Created:
8 years, 7 months ago by scottmg
Modified:
8 years, 6 months ago
CC:
chromium-reviews, erikwright (departed), brettw-cc_chromium.org
Visibility:
Public.

Description

Replace prep_libc.sh with prep_libc.py, and quiet the output Towards addressing two semi-related problems in the linked bugs. One is that the cygwin-run steps are unreliable, especially on Win8, so move away from using shell scripts in gyp actions. The other is that the .sh file let 'lib' echo its arguments, which adds unnecessary noise to the build, especially the quieter ninja build. R=jar@chromium.org BUG=126483, 123026 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=138499

Patch Set 1 #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -41 lines) Patch
M base/allocator/allocator.gyp View 1 chunk +4 lines, -2 lines 0 comments Download
A base/allocator/prep_libc.py View 1 chunk +55 lines, -0 lines 6 comments Download
D base/allocator/prep_libc.sh View 1 chunk +0 lines, -39 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
scottmg
8 years, 7 months ago (2012-05-21 20:08:36 UTC) #1
jar (doing other things)
lgtm
8 years, 7 months ago (2012-05-23 01:43:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/10388215/1
8 years, 7 months ago (2012-05-23 02:14:15 UTC) #3
commit-bot: I haz the power
Try job failure for 10388215-1 (retry) on linux_chromeos for step "compile" (clobber build). It's a ...
8 years, 7 months ago (2012-05-23 02:42:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/10388215/1
8 years, 7 months ago (2012-05-23 05:13:55 UTC) #5
commit-bot: I haz the power
Try job failure for 10388215-1 (retry) (retry) on win_rel for step "sync_unit_tests". It's a second ...
8 years, 7 months ago (2012-05-23 11:21:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/10388215/1
8 years, 7 months ago (2012-05-23 14:15:28 UTC) #7
commit-bot: I haz the power
Change committed as 138499
8 years, 7 months ago (2012-05-23 17:06:58 UTC) #8
Evan Martin
https://chromiumcodereview.appspot.com/10388215/diff/1/base/allocator/prep_libc.py File base/allocator/prep_libc.py (right): https://chromiumcodereview.appspot.com/10388215/diff/1/base/allocator/prep_libc.py#newcode41 base/allocator/prep_libc.py:41: 'build\\intel\\mt_obj\\', perhaps more readable as r'build\intel\mt_obj' '\\'
8 years, 7 months ago (2012-05-23 17:44:15 UTC) #9
jar (doing other things)
Maruel: This change switched to using python... but the invocation is not working a bunch ...
8 years, 6 months ago (2012-05-30 00:32:15 UTC) #10
M-A Ruel
8 years, 6 months ago (2012-05-30 12:55:11 UTC) #11
On 2012/05/30 00:32:15, jar wrote:
> Maruel: This change switched to using python... but the invocation is not
> working a bunch of dev machines.  What is the "official"(?) way that python
> should be invoked as part of a build script?

I thought gyp had code to resolve 'python' path at project generation time. I
guess it doesn't.

https://chromiumcodereview.appspot.com/10388215/diff/1/base/allocator/prep_li...
File base/allocator/prep_libc.py (right):

https://chromiumcodereview.appspot.com/10388215/diff/1/base/allocator/prep_li...
base/allocator/prep_libc.py:7: # This script takes libcmt.lib for VS2005/08/10
and removes the allocation
This should be a docstring.

https://chromiumcodereview.appspot.com/10388215/diff/1/base/allocator/prep_li...
base/allocator/prep_libc.py:21: 
The rest of the code base is formatted with 2 vertical lines between file level
symbols

https://chromiumcodereview.appspot.com/10388215/diff/1/base/allocator/prep_li...
base/allocator/prep_libc.py:41: 'build\\intel\\mt_obj\\',
On 2012/05/23 17:44:15, Evan Martin wrote:
> perhaps more readable as
>   r'build\intel\mt_obj' '\\'

I personally disagree, either a string all r'' or all '', but mixing r'' and ''
is bad taste to me. And since r'\' doesn't work...

https://chromiumcodereview.appspot.com/10388215/diff/1/base/allocator/prep_li...
base/allocator/prep_libc.py:50: cmd = ('lib /nologo /ignore:4006,4014,4221
/remove:%s%s.obj %s' %
Please use a list, not a string.

https://chromiumcodereview.appspot.com/10388215/diff/1/base/allocator/prep_li...
base/allocator/prep_libc.py:52: run(cmd, obj + '.obj')
you shouldn't discard the return code. If one of the execution fails, we want to
know.

Powered by Google App Engine
This is Rietveld 408576698