Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3234)

Unified Diff: chrome/browser/printing/print_dialog_cloud_interative_uitest.cc

Issue 10388214: Make cloud print dialog creation function not use browser list, instead obtain profile and parent w… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/printing/print_dialog_cloud_interative_uitest.cc
===================================================================
--- chrome/browser/printing/print_dialog_cloud_interative_uitest.cc (revision 138829)
+++ chrome/browser/printing/print_dialog_cloud_interative_uitest.cc (working copy)
@@ -16,8 +16,8 @@
#include "base/utf_string_conversions.h"
#include "base/values.h"
#include "chrome/browser/printing/cloud_print/cloud_print_url.h"
+#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/browser.h"
-#include "chrome/browser/ui/browser_list.h"
#include "chrome/browser/ui/browser_window.h"
#include "chrome/browser/ui/webui/chrome_url_data_manager.h"
#include "chrome/common/chrome_paths.h"
@@ -208,8 +208,9 @@
BrowserThread::PostTask(
BrowserThread::UI, FROM_HERE,
base::Bind(&internal_cloud_print_helpers::CreateDialogFullImpl,
+ browser()->profile(), browser()->window()->GetNativeHandle(),
path_to_pdf, string16(), string16(),
- std::string("application/pdf"), true, false));
+ std::string("application/pdf"), false));
}
bool handler_added_;
@@ -239,9 +240,6 @@
#define MAYBE_HandlersRegistered HandlersRegistered
#endif
IN_PROC_BROWSER_TEST_F(PrintDialogCloudTest, MAYBE_HandlersRegistered) {
- BrowserList::SetLastActive(browser());
- ASSERT_TRUE(BrowserList::GetLastActive());
-
AddTestHandlers();
TestController::GetInstance()->set_use_delegate(true);
« no previous file with comments | « chrome/browser/printing/print_dialog_cloud.cc ('k') | chrome/browser/printing/print_dialog_cloud_internal.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698