Fix crash in policy code caused by early shutdown.

Fix crash in policy code caused by early shutdown.

BUG=128328, 127396
TEST=Starting chrome with --try-chrome-again=10001 doesn't crash in policy code anymore


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=138460

[Joao da Silva, 2012-05-21 16:31:18]

This fixes the crash reported by Finnur on issue 128328. The ToastCrasher test
now fails in a NOTREACHED() in important_file_writer.cc, as described in issue
127396.

Please review, thanks!

[Mattias Nissler (ping if slow), 2012-05-21 16:33:37]

http://codereview.chromium.org/10388211/diff/1/chrome/browser/browser_process...
File chrome/browser/browser_process_impl.h (right):

http://codereview.chromium.org/10388211/diff/1/chrome/browser/browser_process...
chrome/browser/browser_process_impl.h:158: // during to an early shutdown.
nit: grammar.

Also, can you please file a bug for fixing up initialization and cleanup order
for the policy stuff?

[Joao da Silva, 2012-05-21 17:14:33]

Filed http://crbug.com/128999.

http://codereview.chromium.org/10388211/diff/1/chrome/browser/browser_process...
File chrome/browser/browser_process_impl.h (right):

http://codereview.chromium.org/10388211/diff/1/chrome/browser/browser_process...
chrome/browser/browser_process_impl.h:158: // during to an early shutdown.
On 2012/05/21 16:33:37, Mattias Nissler wrote:
> nit: grammar.
> 
> Also, can you please file a bug for fixing up initialization and cleanup order
> for the policy stuff?

Done.

[Finnur, 2012-05-21 17:16:44]

LGTM

[Mattias Nissler (ping if slow), 2012-05-21 17:35:49]

lgtm

[commit-bot: I haz the power, 2012-05-22 09:29:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/10388211/3003

[commit-bot: I haz the power, 2012-05-22 12:34:09]

Try job failure for 10388211-3003 (retry) (retry) on win_rel for steps
"base_unittests, sync_unit_tests" (clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-05-22 14:57:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/10388211/3003

[commit-bot: I haz the power, 2012-05-22 23:41:51]

Try job failure for 10388211-3003 (retry) (retry) (retry) on win_rel for step
"sync_unit_tests" (clobber build).
It's a second try, previously, steps "base_unittests, sync_unit_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-05-23 08:36:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/10388211/3003

[commit-bot: I haz the power, 2012-05-23 10:19:28]

Change committed as 138460